Yeah, sorry... I didn't sufficiently scrub the commit message. Simple subclass of AbstractModule that has hashCode/equals to make sure it's only installed once even if multiple places use it. In general it's a bad practice because it breaks down when using the SPI.
sam On May 20, 2014 9:07 PM, "Tavian Barnes" <[email protected]> wrote: > What's ShareableModule? Some Google-internal thing? > > On Tuesday, 20 May 2014 08:57:08 UTC-4, Sam Berlin wrote: >> >> This is likely >> r96e81ba55441<https://code.google.com/p/google-guice/source/detail?r=96e81ba55441fd11c189d903ee2bd1806a23bd70> >> / >> r6c69bcf53d41<https://code.google.com/p/google-guice/source/detail?r=6c69bcf53d4122b0f05f44783c0d8a61afd83911#>. >> These CLs made it so that multibinder/mapbinder bindings follow the same >> rules as Guice for deduplicating exact-same bindings. If Guice finds an >> exact-same binding (e.g, bind to the same key / instance / provider in the >> same scope), it will ignore it. This is an intentional change. >> >> sam >> >> >> On Tue, May 20, 2014 at 2:10 AM, Thomas Suckow <[email protected]> wrote: >> >>> I am seeing a regression in beta4 that allows duplicate bindings in a >>> multibinder even when duplicates are not permitted. >>> >>> I am attempting to git bisect but it takes my system forever to build >>> Guice, so it may be a while before I can locate the problem. >>> >>> If anyone else could look into it, I would appreciate it. >>> >>> - >>> Thomas >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "google-guice" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at http://groups.google.com/group/google-guice. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/google-guice. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/google-guice. For more options, visit https://groups.google.com/d/optout.
