Perf improvements for Guice tend to fall in two categories: Speed up startup, and speed up runtime. Speeding up the startup makes the development lifecycle better -- devs can start/stop/restart their servers faster. Speeding up runtime has more obvious improvements: you can do more things with fewer resources. In aggregate, a faster runtime can make a huge difference to how fast a machine can handle requests.
In general, we haven't found anything pathologically slow for a long time. The last real terrible case (that I can recall) was AssistedInject, and that's been fixed <https://github.com/google/guice/commit/141f800c09d66898ce04c7684330e1e9dc8a31ab> for a long time. There's probably a lot of little internal things that could be cleaned up or optimized, though, and so long as there's benchmarks proving the changes really are optimizing stuff, there's no harm in doing it (if it doesn't complicate the code too much). sam On Tue, Oct 14, 2014 at 1:59 PM, Kevin Burton <[email protected]> wrote: > OK.. silly question, why would this matter? > > The performance of Guice didn't seem pathologically broken. > > What I do is just create all my bindings at startup and then I'm done. > Any complex initialization is done via providers... > > So maybe I'm missing something and there are some use cases that people > are calling getInstance() in a more production or tight loop situation? > > Is this an anti-pattern or actually valuable? > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/google-guice. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-guice/d0227e61-a0bd-40d9-b8db-3aabdc3be423%40googlegroups.com > <https://groups.google.com/d/msgid/google-guice/d0227e61-a0bd-40d9-b8db-3aabdc3be423%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/google-guice. To view this discussion on the web visit https://groups.google.com/d/msgid/google-guice/CAJEBNUdiNTxDLtEZvbJhnOOx%3DxqwUUOd0UvMhJdF9HJ9_Scgdg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
