Hello Daniel,
It's awesome to see the promises integrated in Google Chart !
I did some tests with the testing-loader.js, (I'm still running on the
v44), and found issue when using Edge (v40): loading just stall.
For info, i'm using this code to load the Gviz:
new Promise(function (resolve) {
google.charts.load('44', {
packages: ['table', 'corechart'],
callback: resolve
});
})
.then(function () {
// Do things
})
This code works perfectly fine when using the v45. (so I guess it's time to
move on).
it will be so nice to replace the above by :
google.charts.load('45', {
packages: ['table', 'corechart']
})
.then(function () {
// Do things
});
By the way, I saw that you are using a Promise polyfill in the testing
loader.
I'm sure a lot of people are also importing a promise polyfill, so it will
bloat the code !?
Is it possible to make it optional ? or maybe add it with feature detection
if it's not already there ?
Also, are you adding any polyfill on the global object ?
Best,
Jean-Rémi
On Monday, 29 May 2017 01:15:06 UTC+2, Daniel LaLiberte wrote:
>
> I am seeing some problems loading 41-44 with the testing-loader.js on IE,
> so I'll have to figure out why that is.
>
> My tests worked fine for me with Firefox, and Safari.
>
> Don't bother testing 45.2 with the old loader.js since it won't work. But
> testing-loader.js should work with 45.2, however, if you want to try it.
>
> On Sat, May 27, 2017 at 11:27 PM, 'Ray Thomas' via Google Visualization
> API <[email protected] <javascript:>> wrote:
>
>> and for the sake of completeness:
>>
>> http://hmsgambia.org/crewlist4.htm
>>
>> <script type="text/javascript" src="
>> https://www.gstatic.com/charts/loader.js";></script>
>>
>> google.charts.load('current',{ packages: ['corechart', 'table', 'gauge',
>> 'controls'] }).then(drawChart);
>>
>> Chrome = No, Firefox = No, IE = No, Edge = No - Table does not appear in
>> any of them
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Google Visualization API" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected]
>> <javascript:>.
>> To post to this group, send email to [email protected]
>> <javascript:>.
>> Visit this group at
>> https://groups.google.com/group/google-visualization-api.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/google-visualization-api/28136bca-2886-4527-9901-0f34a2ae9df3%40googlegroups.com
>>
>> <https://groups.google.com/d/msgid/google-visualization-api/28136bca-2886-4527-9901-0f34a2ae9df3%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Daniel LaLiberte <https://plus.google.com/100631381223468223275?prsrc=2>
> [email protected] <javascript:> 5CC, Cambridge MA
>
--
You received this message because you are subscribed to the Google Groups
"Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/google-visualization-api.
To view this discussion on the web visit
https://groups.google.com/d/msgid/google-visualization-api/03f1e867-7cad-4c9a-87b9-1fca88c5e636%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
