Ok thnx that is good news ;] Bart
On Sat, Jan 16, 2010 at 9:34 PM, pamela (Google Employee) <[email protected]> wrote: > Yes, it will be fixed. Please workaround accordingly for now. > > On Sun, Jan 17, 2010 at 5:14 AM, Bart Thate <[email protected]> wrote: >> >> On Sat, Jan 16, 2010 at 7:11 PM, Eyal <[email protected]> wrote: >> > Hi Bart, >> >> Hoi Eyal, >> >> > >> > Did you try to change the waveapi package yourself? >> > >> > That is, change the line: >> > >> > handler(event.properties, context) >> > >> > with the line: >> > >> > handler(event.properties, context, event.type) >> > >> > and your callbacks prototypes to something like this: >> > >> > def onSelfAdded(properties, context, event_type): >> > >> > Hope this helps, >> > Eyal. >> >> I know i can hack the excisting waveapi package, but i hope to see >> this getting the standard in the new API. >> >> Bart >> >> >> > On Jan 16, 7:42 pm, Bart Thate <[email protected]> wrote: >> >> Hello hardworking Googlers, >> >> >> >> I wonder if this following code snippet from waveapi/robot_abstract.py >> >> is going to be fixed in the upcoming API ? >> >> >> >> def HandleEvent(self, event, context): >> >> """Calls all of the handlers associated with an event.""" >> >> for handler in self._handlers.get(event.type, []): >> >> # TODO(jacobly): pass the event in to the handlers directly >> >> # instead of passing the properties dictionary. >> >> logging.debug("EVENT: %s" % dir(event)) >> >> logging.debug("EVENT DATA: %s" % str(event)) >> >> handler(event.properties, context) >> >> >> >> I need the event.type for my callbacks that i implement in my robot. >> >> Dispatching is based on type, so it would be handy to have the type >> >> available. >> >> >> >> Is the new api going to be a new package (like waveapi2) or is the >> >> current waveapi namespace going to be reused ? >> >> >> >> thnx, >> >> >> >> Bart >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups "Google Wave API" group. >> > To post to this group, send email to [email protected]. >> > To unsubscribe from this group, send email to >> > [email protected]. >> > For more options, visit this group at >> > http://groups.google.com/group/google-wave-api?hl=en. >> > >> > >> > >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Google Wave API" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/google-wave-api?hl=en. >> >> >> > > > -- > You received this message because you are subscribed to the Google Groups > "Google Wave API" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-wave-api?hl=en. > >
-- You received this message because you are subscribed to the Google Groups "Google Wave API" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-wave-api?hl=en.
