LGTM. You got that figured out really fast, nicely done!
On Thu, Sep 4, 2008 at 4:10 PM, John LaBanca <[EMAIL PROTECTED]> wrote: > Alex - > More review fun. > Description: > ========= > A recent change in MenuBar causes the MenuBar to focus on itself when the > user highlights a MenuItems with the mouse (or programatically). This makes > sense from the perspective of the MenuBar because it means that a user can > seamlessly switch between mouse and keyboard input. However, it also means > that as soon as soon as the first suggestion in a SuggestBox is highlighted > by default, the TextBox loses focus and the user can no longer type in > Safari or Google Chrome. > Fix: > === > The itemOver method now takes an optional boolean to focus on the MenuBar. > The method is package protected, so we can change the method header. > Testing: > ====== > Verified the fix manually on IE, Chrome, Safari, and FF3. Also verified the > Unit tests pass in IE hosted mode. > -- > Thanks, > John LaBanca > [EMAIL PROTECTED] > -- Alex Rudnick swe, gwt, atl --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
