LGTM see nits below. On Thu, Sep 4, 2008 at 3:42 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> Hello Miguel, > > I would like for you to review the attached patch to the Maps API. It > changes the Placemark object to be a subclass of JavaScriptObject for > better efficiency. > > There is a user-visible side effect to this change - there were some > passing around of Placemarks as arrays that I changed to JsArray. > > M maps/maps/test/com/google/gwt/maps/client/geocode/GeocodeTest.java LG > M maps/maps/src/com/google/gwt/maps/client/impl/JsUtil.java LG - Nit asJavaScriptObject is no longer necessary. > > M maps/maps/src/com/google/gwt/maps/client/impl/GeocoderImpl.java LG M maps/maps/src/com/google/gwt/maps/client/geocode/Placemark.java LG Nits 50, 78 the || null is no longer necessary Future: It looks like placemark is really a shortcut for traversing a collection of JSOs. I'm not really sure where that JSO structure is documented however. > > M > maps/maps/src/com/google/gwt/maps/client/geocode/LocationCallback.java LG > > M maps/maps/src/com/google/gwt/maps/client/geocode/Geocoder.java LG M > > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/Geocoder2Demo.java LG > M > > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/RoutedDirectionsDemo.java > LG > > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
