That's what the weird test in "put" is for, as the current working hypothesis is that removing all keys that appear in the prototype object will prevent this problem. I went through and tested a bunch of them, so it seems solid, but only time will tell if all the browsers/random word combinations are licked. This is one of the reasons these classes are going into incubator rather then gwt to begin with.
On Fri, Sep 5, 2008 at 12:21 AM, Folke <[EMAIL PROTECTED]> wrote: > > What happens when you use "prototype" or "length" or "name" as keys? I > remember a FastStringMap somewhere in GWT that prepends each key with > a colon to avoid collision. > > > > On Sep 5, 5:45 am, "Emily Crutcher" <[EMAIL PROTECTED]> wrote: > > Ah, I see what happened, when tortoise makes a branch of the working > > directory it, logically enough, does not include files which have not > been > > officially added to trunk. The files should be there now. > > > > > > > > On Thu, Sep 4, 2008 at 7:36 PM, Folke <[EMAIL PROTECTED]> wrote: > > > > > Hi Emily > > > > > Did you commit the files? I'm really interested in your > > > implementation. This directory is empty: > > > > >http://code.google.com/p/google-web-toolkit-incubator/source/browse/b. > .. > > > > > Folke > > > > > On Sep 5, 12:28 am, "Emily Crutcher" <[EMAIL PROTECTED]> wrote: > > > > John, master of JRE collections, Could you review this? > > > > > > For big applications, map's performance can end up being a > bottleneck. > > > This > > > > code review introduces the AbstractJsMap, which is a slightly > modified > > > API > > > > so that we can create faster map implementations. > > > > > > The code contains new directories, so here is a read-only branch with > the > > > > code in it: > > >http://code.google.com/p/google-web-toolkit-incubator/source/browse/#. > .. > > > > > > Attached is the benchmark for putting then getting 1000 through > 10,000 > > > > strings, where HashMap is compared to the new JsStringMap. For the > > > compiled > > > > put/get benchmark, it is between 300%-500% faster. > > > > > > Thanks, > > > > > > Emily > > > > > > -- > > > > "There are only 10 types of people in the world: Those who understand > > > > binary, and those who don't" > > > > > > Mozilla4_003.png > > > > 22KViewDownload > > > > > > report-JsStringMap.xml > > > > 11KViewDownload > > > > -- > > "There are only 10 types of people in the world: Those who understand > > binary, and those who don't" > > > -- "There are only 10 types of people in the world: Those who understand binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
