Thanks Chief! On Mon, Sep 8, 2008 at 2:08 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> On Mon, Sep 8, 2008 at 1:43 PM, Miguel Méndez <[EMAIL PROTECTED]> wrote: > >> LGTM with one nit. I think that you want MarkerOptions.newInstance >> instead of MarkerOptions.getInstance since the the factory method always >> returns a new instance of the JSO. >> > > Changed the name of the constructors to newInstance. > Committed as r761. Thanks for the review! > > > >> >> >> On Thu, Sep 4, 2008 at 4:10 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >>> Hello Miguel, >>> >>> I would like for you to review the attached patch that converts >>> MarkerOptions to a JavaScript overlay. Following the convention in >>> Josh Bloch's Effective Java, I've named the factory method >>> 'getInstance()'. I had to modify several demos to get rid of using hte >>> constructor. >>> >>> >>> M maps/maps/src/com/google/gwt/maps/client/overlay/Icon.java >>> M >>> maps/maps/src/com/google/gwt/maps/client/overlay/MarkerOptions.java >>> M >>> >>> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DragMarkerDemo.java >>> M >>> >>> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/MapEventDemo.java >>> M >>> >>> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java >>> M >>> >>> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java >>> >>> >>> -- >>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>> http://code.google.com/webtoolkit/ >>> >> >> >> >> -- >> Miguel >> >> >> >> > > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
