Committed as r763. On Mon, Sep 8, 2008 at 1:49 PM, Miguel Méndez <[EMAIL PROTECTED]> wrote:
> LGTM with [get|new]Instance method nit. > > > On Fri, Sep 5, 2008 at 4:48 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > >> Sorry, forgot to attach the actual patch. >> >> 2008/9/5 Eric Ayers <[EMAIL PROTECTED]>: >> > Hello Miguel, >> > >> > I would like for you to review this patch which converts Point and >> TileIndex objects to be sublasses of JavaScriptObject. >> > >> > M maps/test/com/google/gwt/maps/client/overlay/MarkerTest.java >> > M >> maps/test/com/google/gwt/maps/client/impl/MinimumMapVersionTest.java >> > M maps/test/com/google/gwt/maps/client/MapWidgetEventsTest.java >> > M maps/test/com/google/gwt/maps/client/geom/ProjectionTest.java >> > M maps/src/com/google/gwt/maps/client/overlay/Icon.java >> > M maps/src/com/google/gwt/maps/client/geom/TileIndex.java >> > M maps/src/com/google/gwt/maps/client/geom/Point.java >> > M maps/src/com/google/gwt/maps/client/geom/Bounds.java >> > M maps/src/com/google/gwt/maps/client/impl/JsUtil.java >> > D maps/src/com/google/gwt/maps/client/impl/PointImpl.java >> > M maps/src/com/google/gwt/maps/client/impl/BoundsImpl.java >> > >> > -- >> > Eric Z. Ayers - GWT Team - Atlanta, GA USA >> > http://code.google.com/webtoolkit/ >> > >> >> >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ >> > > > > -- > Miguel > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
