[gwt-contrib] Re: [gwt-google-apis commit] r766 - trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client

[Miguel Méndez]

LGTM

On Mon, Sep 8, 2008 at 3:02 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:

> This patch was submitted to fix another build break, this time in the
> HelloMaps sample.
>
> -Eric.
>
>
> ---------- Forwarded message ----------
> From: <[EMAIL PROTECTED]>
> Date: Mon, Sep 8, 2008 at 3:01 PM
> Subject: [gwt-google-apis commit] r766 -
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client
> To: [EMAIL PROTECTED]
>
>
>
> Author: [EMAIL PROTECTED]
> Date: Mon Sep  8 12:01:18 2008
> New Revision: 766
>
> Modified:
>
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
>
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
>
> Log:
> Fixes a build break when Point() was changed to a JavaScript overlay.
>
> Patch by: zundel
> Review by: mmendez
>
>
>
> Modified:
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
>
> ==============================================================================
> ---
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
> (original)
> +++
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
> Mon Sep  8 12:01:18 2008
> @@ -88,8 +88,8 @@
>      baseIcon.setShadowURL("http://www.google.com/mapfiles/shadow50.png";);
>      baseIcon.setIconSize(new Size(20, 34));
>      baseIcon.setShadowSize(new Size(37, 34));
> -    baseIcon.setIconAnchor(new Point(9, 34));
> -    baseIcon.setInfoWindowAnchor(new Point(9, 2));
> +    baseIcon.setIconAnchor(Point.newInstance(9, 34));
> +    baseIcon.setInfoWindowAnchor(Point.newInstance(9, 2));
>      // TOOD(sgross): undocumented?
>      // baseIcon.setInfoShadowAnchor(new GPoint(18, 25));
>    }
>
> Modified:
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
>
> ==============================================================================
> ---
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
> (original)
> +++
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
> Mon Sep  8 12:01:18 2008
> @@ -87,8 +87,8 @@
>
> icon.setShadowURL("
> http://labs.google.com/ridefinder/images/mm_20_shadow.png";);
>      icon.setIconSize(new Size(12, 20));
>      icon.setShadowSize(new Size(22, 20));
> -    icon.setIconAnchor(new Point(6, 20));
> -    icon.setInfoWindowAnchor(new Point(5, 1));
> +    icon.setIconAnchor(Point.newInstance(6, 20));
> +    icon.setInfoWindowAnchor(Point.newInstance(5, 1));
>
>      // Add 10 markers to the map at random locations
>      LatLngBounds bounds = map.getBounds();
>
> >
>
>
>
> --
> Eric Z. Ayers - GWT Team - Atlanta, GA USA
> http://code.google.com/webtoolkit/
>



-- 
Miguel

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---