On Tue, Sep 9, 2008 at 1:24 PM, John Tamplin <[EMAIL PROTECTED]> wrote:
> On Tue, Sep 9, 2008 at 1:11 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> What was misplaced about this? >> > > The break needs to happen if a plugin was successfully found rather than if > an error occurred trying to initialize it. > I don't understand. If a plugin was found but failed to connect, and we call the module load error function, why would we continue iterating through the list? Once you've found a plugin that loads, that's the right plugin; just because it fails to connect doesn't mean you should keep trying, does it? Or did something fundamentally change and we need to rethink the load process? > > >> By the way, we're at a point now where changes to the OOPHM branch need to >> be reviewed. >> > > This was to changes/jat/oophm-trunk-r3274, not branches/oophm. I am trying > to get Sam's code, which predates the JSNI rewrite, working there before > porting it to the new branch. > Gotcha. --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
