Optional, it might be helpful to have a check that, if both files are available, warns you that there're two sources and could be in conflict. But it's a cherry; I'm not sure it's worth any real effort, so I'm back to my opening "LGTM".
On Tue, Sep 9, 2008 at 2:10 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > Yep, that was actually deliberate, as it should be the case that any > properties defined locally will trump the default ones, which is as it > should be. > > On Tue, Sep 9, 2008 at 2:05 PM, Freeland Abbott < > [EMAIL PROTECTED]> wrote: > >> LGTM, but as written if users have both property files the in-project-dir >> one will "win" on any overlaps, because ant properties are immutable. That >> may not be a problem, but I wanted to call it out. >> >> On Mon, Sep 8, 2008 at 11:30 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote: >> >>> Adds a check for a global-incubator.properties file in the directory >>> above the working gwt-incubator directory. The purpose of this change is to >>> allow people with multiple gwt-incubator directories to have a single >>> properties file associated with all of them. >>> >>> -- >>> "There are only 10 types of people in the world: Those who understand >>> binary, and those who don't" >>> >> >> > > > -- > "There are only 10 types of people in the world: Those who understand > binary, and those who don't" > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
