On Mon, Sep 8, 2008 at 5:37 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> Hello Miguel, > > This is the halfway point - 9 classes down, 9 to go. > > I would like for you to review the attached patch which converts the Bounds > object to a JavaScript overlay. I changed the behavior of the 'extends()' > method to just mirror the JavaScript method instead of cloning the bounds > object. I also added a new factory method which takes 4 int arguments. > > Since I made those changes and there were no references to this object I > could test with, I added a unit test. > > A maps/maps/test/com/google/gwt/maps/client/geom/BoundsTest.java > LG > > M maps/maps/src/com/google/gwt/maps/client/geom/Bounds.java > 37 - This Bounds construction is not part of the Maps API proper and it is only called from our test code. Do we still need it? 105, 114, 123, 132 - Should get[Max|Min][X|Y] just return doubles? The JS API just states that this is a Number however the documentation would lead you to believe that it is really an integer value. It seems like the safest thing to do would be to use a double. Maybe Pam could shed some light? This would call into question the newPoint method. > D maps/maps/src/com/google/gwt/maps/client/impl/BoundsImpl.java > LG > > M maps/maps/test/com/google/gwt/maps/MapsTestSuite.java > LG > > -Eric. > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
