On Wed, Sep 10, 2008 at 8:56 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote:

> LGTM - nits: 40, 49 won't work until Duration and Distance are converted.
>  Maybe you should add a TODO like you did on line 74 until those are
> converted?
>

Good catch. Duration and Distance weren't on my list of classes to convert.
Committed as r769.


>
>
> On Mon, Sep 8, 2008 at 3:51 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
>
>> Hi Miguel,
>>
>> I would like for you to review the attached patch.  It converts the Route
>> object to a JavaScript overlay.
>>
>> D      maps/maps/src/com/google/gwt/maps/client/impl/RouteImpl.java
>> M      maps/maps/src/com/google/gwt/maps/client/geocode/Route.java
>> --
>> Eric Z. Ayers - GWT Team - Atlanta, GA USA
>> http://code.google.com/webtoolkit/
>>
>
>
>
> --
> Miguel
>



-- 
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to