On Tue, Sep 9, 2008 at 11:17 AM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> Hello Miguel, > > I would like for you to review the attached patch. > > This change converts the Size and Icon classes to JavaScript overlays, > meaning you must use the 'newInstance()' static method to construct them. I > did them together because there were inter-dependencies. > > I also broke up the Marker test and Icon test into two separate test > cases. The getImageMap() and setImageMap() now have a JsArray version and > an int[] version. > > M maps/maps/test/com/google/gwt/maps/MapsTestSuite.java > LG > M maps/maps/test/com/google/gwt/maps/client/overlay/MarkerTest.java > LG > A maps/maps/test/com/google/gwt/maps/client/overlay/IconTest.java > LG > > M > maps/maps/src/com/google/gwt/maps/client/control/ControlPosition.java > LG - We do plan on converting ControlPosition as well right? > > M maps/maps/src/com/google/gwt/maps/client/overlay/Polygon.java > 54 - typo "creae" -> "create" > > M maps/maps/src/com/google/gwt/maps/client/overlay/Icon.java > LG with one nit: 41 - why do we set the anchor to 0,0 for newInstance()? > > M maps/maps/src/com/google/gwt/maps/client/overlay/MarkerOptions.java > LG > > M maps/maps/src/com/google/gwt/maps/client/geom/Size.java > LG > M maps/maps/src/com/google/gwt/maps/client/MapWidget.java > > > D maps/maps/src/com/google/gwt/maps/client/impl/SizeImpl.java > LG > D maps/maps/src/com/google/gwt/maps/client/impl/IconImpl.java > LG > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
