[gwt-contrib] Re: [gwt-google-apis commit] r771 - trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client

[Miguel Méndez]

LGTM

On Wed, Sep 10, 2008 at 10:20 AM, Eric Ayers <[EMAIL PROTECTED]> wrote:

> Hi Miguel,
>
> I left some files from the HelloMaps sample out of the patch from the last
> review.  Could you TBR them for me?
>
>
> ---------- Forwarded message ----------
> From: <[EMAIL PROTECTED]>
> Date: Wed, Sep 10, 2008 at 10:15 AM
> Subject: [gwt-google-apis commit] r771 -
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client
> To: [EMAIL PROTECTED]
>
>
>
> Author: [EMAIL PROTECTED]
> Date: Wed Sep 10 07:14:41 2008
> New Revision: 771
>
> Modified:
>
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
>
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
>
> Log:
> Demos needed updating after Icon conversion to JS overlays.
>
> Patch by: zundel
> Review by: mmendez(TBR)
>
>
>
> Modified:
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
>
> ==============================================================================
> ---
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
> (original)
> +++
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java
> Wed Sep 10 07:14:41 2008
> @@ -84,10 +84,10 @@
>
>      // Create a base icon for all of our markers that specifies the
>      // shadow, icon dimensions, etc.
> -    baseIcon = new Icon();
> +    baseIcon = Icon.newInstance();
>      baseIcon.setShadowURL("http://www.google.com/mapfiles/shadow50.png";);
> -    baseIcon.setIconSize(new Size(20, 34));
> -    baseIcon.setShadowSize(new Size(37, 34));
> +    baseIcon.setIconSize(Size.newInstance(20, 34));
> +    baseIcon.setShadowSize(Size.newInstance(37, 34));
>      baseIcon.setIconAnchor(Point.newInstance(9, 34));
>      baseIcon.setInfoWindowAnchor(Point.newInstance(9, 2));
>      // TOOD(sgross): undocumented?
> @@ -118,7 +118,7 @@
>    private Marker createMarker(LatLng point, int index) {
>      // Create a lettered icon for this point using our icon class
>      final char letter = (char) ('A' + index);
> -    Icon icon = new Icon(baseIcon);
> +    Icon icon = Icon.newInstance(baseIcon);
>      icon.setImageURL("http://www.google.com/mapfiles/marker"; + letter
> + ".png");
>      MarkerOptions options = MarkerOptions.newInstance();
>      options.setIcon(icon);
>
> Modified:
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
>
> ==============================================================================
> ---
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
> (original)
> +++
>
> trunk/maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java
> Wed Sep 10 07:14:41 2008
> @@ -82,11 +82,11 @@
>      map.clearOverlays();
>
>      // Create our "tiny" marker icon
> -    Icon icon = new Icon(
> +    Icon icon = Icon.newInstance(
>          "http://labs.google.com/ridefinder/images/mm_20_red.png";);
>
> icon.setShadowURL("
> http://labs.google.com/ridefinder/images/mm_20_shadow.png";);
> -    icon.setIconSize(new Size(12, 20));
> -    icon.setShadowSize(new Size(22, 20));
> +    icon.setIconSize(Size.newInstance(12, 20));
> +    icon.setShadowSize(Size.newInstance(22, 20));
>      icon.setIconAnchor(Point.newInstance(6, 20));
>      icon.setInfoWindowAnchor(Point.newInstance(5, 1));
>
>
> >
>
>
>
> --
> Eric Z. Ayers - GWT Team - Atlanta, GA USA
> http://code.google.com/webtoolkit/
>



-- 
Miguel

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---