LGTM On Wed, Sep 10, 2008 at 11:24 AM, John LaBanca <[EMAIL PROTECTED]> wrote:
> Emily - > > Please do a code review on this patch which adds some additional styles to > TabBar. > > Description: > ========= > It would be nice to add the styles gwt-TabBarFirstWrapper and > gwt-TabBarRestWrapper to the TD cells that wrap the gwt-TabBarFirst and > gwt-TabBarRest divs so the cells themselves can be styled. Currently, we do > provide the style gwt-TabBarItemWrapper on the TD cells around TabBar > items. The primary use case is to hide the td cell that contains the > TabBarRest element so it doesn't push out on its container, which can happen > in some layouts. > > Fix: > === > Added the styles. I use "gwt-TabBarFirst-wrapper" and > "gwt-TabBarRest-wrapper" to be consistent with the existing style > "gwt-TabBarItem-wrapper". > > Testing: > ====== > I manually verified that the styles are applied correctly in all main > browsers. > > Thanks, > John LaBanca > [EMAIL PROTECTED] > -- "There are only 10 types of people in the world: Those who understand binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
