LGTM On Wed, Sep 10, 2008 at 12:52 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> > > On Wed, Sep 10, 2008 at 9:48 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote: > >> >> On Tue, Sep 9, 2008 at 3:54 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >>> Hello Miguel, >>> >>> I've combined the conversion of several classes into one patch because of >>> the overlap. >>> >>> - PolylineOptions >>> - PolygonOptions >>> - Fixed constructor name in PolyStyleOptions.java >>> - Fixed references to above. >>> - Changed some references to PolylineOptions to EncodedPolyline... that >>> was weird! >>> >>> M maps/maps/test/com/google/gwt/maps/client/overlay/PolygonTest.java >>> >> LG >> >> >>> >>> M >>> maps/maps/src/com/google/gwt/maps/client/overlay/PolygonOptions.java >>> >> LG - consider adding a newInstance(boolean clickable) method. >> > done. > > >> >>> >>> A >>> maps/maps/src/com/google/gwt/maps/client/overlay/PolylineOptions.java >>> >> LG - This is one place where we could provide an additional newInstance >> overload to specify clickable and geodesic. >> > created newInstance(boolean clickable) and newInstance(boolean clickable, > boolean geodesic) > >> >> >>> >>> M >>> maps/maps/src/com/google/gwt/maps/client/overlay/EncodedPolyline.java >>> >> LG >> >> >>> >>> M >>> maps/maps/src/com/google/gwt/maps/client/overlay/PolyStyleOptions.java >>> >> LG >> >> >>> M maps/maps/src/com/google/gwt/maps/client/overlay/Polygon.java >>> >> LG >> >> >>> M maps/maps/src/com/google/gwt/maps/client/overlay/Polyline.java >>> >> LG >> >> >>> D >>> maps/maps/src/com/google/gwt/maps/client/impl/PolyStyleOptionsImpl.java >>> >> LG >> >> >>> M >>> maps/maps/src/com/google/gwt/maps/client/impl/PolylineFactoryImpl.java >>> >> LG - Is this an overlay conversion candidate? >> >> D >>> maps/maps/src/com/google/gwt/maps/client/impl/PolygonOptionsImpl.java >>> >> LG >> >> >>> D >>> maps/maps/src/com/google/gwt/maps/client/impl/PolylineOptionsImpl.java >>> >> LG >> >> >>> M >>> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DrawingOverlayDemo.java >>> >> LG >> >> M >>> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/OverlayDemo.java >>> >> LG >> >> >>> >>> >>> -- >>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>> http://code.google.com/webtoolkit/ >>> >> >> >> >> -- >> Miguel >> > > I've gone ahead and committed this patch as r774, but attached it in case > you feel it needs further review. I Modified the tests a bit, adding a new > PolylineTest class. > > M maps/maps/test/com/google/gwt/maps/MapsTestSuite.java > M maps/maps/test/com/google/gwt/maps/client/overlay/PolygonTest.java > M maps/maps/src/com/google/gwt/maps/client/overlay/PolygonOptions.java > A > maps/maps/src/com/google/gwt/maps/client/overlay/PolylineOptions.java > M > maps/maps/src/com/google/gwt/maps/client/overlay/EncodedPolyline.java > M > maps/maps/src/com/google/gwt/maps/client/overlay/PolyStyleOptions.java > M maps/maps/src/com/google/gwt/maps/client/overlay/Polygon.java > M maps/maps/src/com/google/gwt/maps/client/overlay/Polyline.java > D > maps/maps/src/com/google/gwt/maps/client/impl/PolyStyleOptionsImpl.java > M > maps/maps/src/com/google/gwt/maps/client/impl/PolylineFactoryImpl.java > D > maps/maps/src/com/google/gwt/maps/client/impl/PolygonOptionsImpl.java > D > maps/maps/src/com/google/gwt/maps/client/impl/PolylineOptionsImpl.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DrawingOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/OverlayDemo.java > > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
