Thanks! Committed as r783. On Thu, Sep 11, 2008 at 11:03 AM, Joel Webber <[EMAIL PROTECTED]> wrote:
> Sorry I missed this one. LGTM! > > > On Mon, Sep 8, 2008 at 1:05 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > >> Hello Joel, >> >> Thanks for looking at this. Attached is an updated patch. >> >> In my demo app, consolidating beginAttach() and finishAttach() into the >> finishAttach() works fine. So I was able to remove a 2 of the handlers and >> all of the calls to 'beginAttach()'. I renamed 'finishAttach()' to just >> 'attach()'. >> >> -Eric. >> >> On Thu, Sep 4, 2008 at 4:17 PM, Joel Webber <[EMAIL PROTECTED]> wrote: >> >>> This approach makes sense to me overall. I do have one question, though. >>> Is there any particular reason for separating beginAttach() and >>> finishAttach() in VirtualPanel? From what I see here, it looks like you >>> could simply do all of it at once in onInfoWindowOpen(), onMaximizeEnd(), >>> and onResroteEnd(). This would probably allow you to get rid of the >>> onMaximizeClick() and onRestoreClick() handlers. >>> Of course, I could be missing something. >>> >>> On Thu, Sep 4, 2008 at 11:49 AM, Eric Ayers <[EMAIL PROTECTED]> wrote: >>> >>>> Joel, >>>> >>>> Would you please review the attached patch that solves a problem related >>>> when widgets need to be attached/detached from panels for the Maps >>>> InfoWindow. >>>> >>>> It addresses issue 156 in gwt-google-apis: >>>> http://code.google.com/p/gwt-google-apis/issues/detail?id=156 >>>> >>>> M maps/maps/src/com/google/gwt/maps/client/InfoWindow.java >>>> >>>> Thanks, >>>> -Eric. >>>> -- >>>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>>> http://code.google.com/webtoolkit/ >>>> >>> >>> >> >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ >> > > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
