Overall LGTM, 1) You might want to put a small comment that you can't do, settings.put(CompilerOptions.OPTION_Source, CompilerOptions.VERSION_1_6); settings.put(CompilerOptions.OPTION_TargetPlatform, CompilerOptions.VERSION_1_5);
2) I don't think you want to unconditionally set the version to 1.5. I'd rather that we only specifically change versions 1.6 to 1.5. Let the version pass through unmolested otherwise. On Thu, Sep 11, 2008 at 3:36 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Toby: > > Can u review attached patch to support Java 6 language? It rewrites the > bytecodes back to Java 5 in a 1.5 VM. > > kthxbai, > Scott > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
