Thanks for the review. I fixed the formatting and committed as r784. On Fri, Sep 12, 2008 at 9:11 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote:
> LGTM with one nit below. > > On Thu, Sep 11, 2008 at 10:56 AM, Eric Ayers <[EMAIL PROTECTED]> wrote: > >> Hello Miguel, >> >> I would like for you to review the attached patch. It is another >> straightforward JS overlay conversion - this time of PolyEditingOptions. >> - Updated some of the javadoc. >> - Added to the Polyline unit test >> - In the process of writing the unit test, I discovered that >> Polyline.setEditingEnabled() must be called after the polyline was added to >> the map, so I documented it in the javadoc. >> >> M maps/maps/test/com/google/gwt/maps/client/overlay/PolylineTest.java >> M >> maps/maps/src/com/google/gwt/maps/client/overlay/PolyEditingOptions.java >> M maps/maps/src/com/google/gwt/maps/client/overlay/Polygon.java >> > Nit: There are a few formatting issues. Specifically, there is a '+' and > an additional '*' in the javadoc for addPolygonVisibilityChangedHandler on > line 286. > > >> M maps/maps/src/com/google/gwt/maps/client/overlay/Polyline.java >> D >> maps/maps/src/com/google/gwt/maps/client/impl/PolyEditingOptionsImpl.java >> M >> maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DrawingOverlayDemo.java >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ >> > > > > -- > Miguel > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
