LGTM - Don't forget to set the mime type and line ending properties for the new files.
What is the resolution for the DirectionResults TODOs? Is this future work? On Thu, Sep 11, 2008 at 2:29 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > Hello Miguel, > > I would like for you to review the attached patch. Its pretty big. > > This patch converts LatLng and LatLngBounds to JavaScript overlays. > > - Changes all constructors from new LatLng(...) to > LatLng.newInstance(...) > - Adds unit tests for LatLng and LatLngBounds > - Updates the Drawing demo (there were cases where changing the input > values caused the demo to fail) > - Found a bug in DirectionResults.getPolyline() - this will be fixed when > converting Polyline to a JSO subclass. > - Removed LatLngImpl and LatLngBoundsImpl classes. > > M maps/maps/test/com/google/gwt/maps/MapsTestSuite.java > M maps/maps/test/com/google/gwt/maps/client/overlay/MarkerTest.java > M maps/maps/test/com/google/gwt/maps/client/overlay/OverlayTest.java > M > maps/maps/test/com/google/gwt/maps/client/overlay/MarkerEventsTest.java > M maps/maps/test/com/google/gwt/maps/client/overlay/PolygonTest.java > M > maps/maps/test/com/google/gwt/maps/client/overlay/PolyEventsTest.java > M maps/maps/test/com/google/gwt/maps/client/overlay/IconTest.java > M maps/maps/test/com/google/gwt/maps/client/overlay/PolylineTest.java > M maps/maps/test/com/google/gwt/maps/client/MapWidgetTest.java > M maps/maps/test/com/google/gwt/maps/client/MapsNotInstalledTest.java > M > maps/maps/test/com/google/gwt/maps/client/impl/MinimumMapVersionTest.java > M > maps/maps/test/com/google/gwt/maps/client/geocode/DirectionsTest.java > M maps/maps/test/com/google/gwt/maps/client/MapWidgetEventsTest.java > A maps/maps/test/com/google/gwt/maps/client/geom/LatLngTest.java > M maps/maps/test/com/google/gwt/maps/client/geom/ProjectionTest.java > A maps/maps/test/com/google/gwt/maps/client/geom/LatLngBoundsTest.java > M maps/maps/test/com/google/gwt/maps/client/InfoWindowEventsTest.java > M maps/maps/test/com/google/gwt/maps/client/CopyrightEventTest.java > M maps/maps/src/com/google/gwt/maps/client/overlay/Polygon.java > M maps/maps/src/com/google/gwt/maps/client/overlay/Polyline.java > M maps/maps/src/com/google/gwt/maps/client/geom/LatLng.java > M maps/maps/src/com/google/gwt/maps/client/geom/LatLngBounds.java > M maps/maps/src/com/google/gwt/maps/client/MapWidget.java > D maps/maps/src/com/google/gwt/maps/client/impl/LatLngImpl.java > M maps/maps/src/com/google/gwt/maps/client/impl/PolygonImpl.java > M maps/maps/src/com/google/gwt/maps/client/impl/JsUtil.java > M maps/maps/src/com/google/gwt/maps/client/impl/PolylineImpl.java > D maps/maps/src/com/google/gwt/maps/client/impl/LatLngBoundsImpl.java > M maps/maps/src/com/google/gwt/maps/client/geocode/Placemark.java > M > maps/maps/src/com/google/gwt/maps/client/geocode/DirectionResults.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DrawingOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/GroundOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/ControlsDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/GeoRssOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/CustomMapTypeDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/SimpleDirectionsDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/AnimateDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DragMarkerDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/MapEventDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/EventDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/OverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/KmlOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/ClickDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/MarkerInfoWindowDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/Geocoder2Demo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/DragCursorDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/CustomControlDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/CustomOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconClassDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/MapTypeDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/TrafficOverlayDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/InfoWindowDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/RoutedDirectionsDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/GeocoderDemo.java > M > maps/samples/hellomaps/src/com/google/gwt/maps/sample/hellomaps/client/IconDemo.java > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
