[gwt-contrib] [google-web-toolkit commit] r3662 - trunk/user/test/com/google/gwt/i18n/client

[codesite-noreply]

Author: [EMAIL PROTECTED]
Date: Wed Sep 17 08:51:15 2008
New Revision: 3662

Modified:
    trunk/user/test/com/google/gwt/i18n/client/TimeZoneTest.java

Log:
Fixed the failing test in TimeZoneTest -- we were asking it to parse an
undefined time and Java and JavaScript had differing interpretations. Need  
to
ask Shanjian what to do for nonexistant time situations...

patch by: ajr, rdayal (pair prog)


Modified: trunk/user/test/com/google/gwt/i18n/client/TimeZoneTest.java
==============================================================================
--- trunk/user/test/com/google/gwt/i18n/client/TimeZoneTest.java        
(original)
+++ trunk/user/test/com/google/gwt/i18n/client/TimeZoneTest.java        Wed Sep 
17  
08:51:15 2008
@@ -16,9 +16,9 @@

  package com.google.gwt.i18n.client;

-import com.google.gwt.junit.client.GWTTestCase;
  import com.google.gwt.core.client.GWT;
  import com.google.gwt.i18n.client.constants.TimeZoneConstants;
+import com.google.gwt.junit.client.GWTTestCase;

  import java.util.Date;

@@ -55,18 +55,18 @@

      DateTimeFormat fmt = DateTimeFormat.getLongDateTimeFormat();
      Date dateMarchBefore = fmt.parse("March 11, 2007 01:00:00 AM GMT-800");
-    Date dateMarchAfter = fmt.parse("March 11, 2007 02:00:00 AM GMT-800");
+    Date dateMarchAfter = fmt.parse("March 11, 2007 03:01:00 AM GMT-800");
      Date dateJuly = fmt.parse("July 11, 2007 07:00:00 AM GMT-800");

      Date dateNovemberBefore = fmt.parse("November 4, 2007 00:00:00 AM  
GMT-800");
      Date dateNovemberAfter = fmt.parse("November 4, 2007 02:00:00 AM  
GMT-800");
+
+    assertTrue("July should be DST.", usPacific.isDaylightTime(dateJuly));
+    assertTrue("Late March should be DST",  
usPacific.isDaylightTime(dateMarchAfter));
+    assertTrue("Early March should not be  
DST", !usPacific.isDaylightTime(dateMarchBefore));

-    assertTrue(usPacific.isDaylightTime(dateJuly));
-    assertTrue(usPacific.isDaylightTime(dateMarchAfter));
-    assertTrue(!usPacific.isDaylightTime(dateMarchBefore));
-
-    assertTrue(!usPacific.isDaylightTime(dateNovemberAfter));
-    assertTrue(usPacific.isDaylightTime(dateNovemberBefore));
+    assertTrue("Late November should not be  
DST", !usPacific.isDaylightTime(dateNovemberAfter));
+    assertTrue("Early November should be DST",  
usPacific.isDaylightTime(dateNovemberBefore));
    }

    public void testNames() {

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---