LGTM - Just like we realized while discussing this change, you'll need to extend Overlay.createPeer to instantiate the other built-in overlay types. That will make ensure that the java type for overlay types is always correct which may make the isXXX methods unnecessary (or you could have them return the correct java type) -- your call.
On Thu, Sep 18, 2008 at 10:32 AM, Eric Ayers <[EMAIL PROTECTED]> wrote: > Sorry, the previous patch left out an update to Marker.java. Updated patch > vs. r800. > > > On Thu, Sep 18, 2008 at 10:24 AM, Eric Ayers <[EMAIL PROTECTED]> wrote: > >> Hi Miguel, >> >> These are all good suggestions, especially the one about including all of >> the source code. I've updated the patch. >> >> >> On Thu, Sep 18, 2008 at 9:48 AM, Miguel Méndez <[EMAIL PROTECTED]>wrote: >> >>> Should InfoWindow be included in this patch? >>> Shouldn't the Overlay.createPeer method perform the tests on the >>> JavaScriptObject and return the correct concrete wrapper class? >>> >>> >>> On Tue, Sep 16, 2008 at 2:19 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >>> >>>> Hello Miguel, >>>> >>>> I would like you to review the attached patch. This patch addresses >>>> issue 170 >>>> >>>> http://code.google.com/p/gwt-google-apis/issues/detail?id=170 >>>> >>>> This change makes InfoWindow extend the ConcreteOverlay class. It also >>>> adds the methods isInfoWindow(), isPolyline(), isPolygon(), and isMarker() >>>> to the Overlay class. >>>> >>>> M >>>> maps/maps/test/com/google/gwt/maps/client/overlay/OverlayTest.java >>>> M maps/maps/src/com/google/gwt/maps/client/overlay/Overlay.java >>>> -- >>>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>>> http://code.google.com/webtoolkit/ >>>> >>> >>> >>> >>> -- >>> Miguel >>> >> >> >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ >> > > > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
