LGTM, just a couple of small changes: In the onBrowserEvent for the delegate pattern, it would be slightly more efficient to check for enabled then return rather then checking for enabled in each case stanza.
"Enable or disable a table" --> "Enable or disable a tab" Should add the new style to the javadoc of TabBar. On Fri, Sep 19, 2008 at 1:17 PM, John LaBanca <[EMAIL PROTECTED]> wrote: > Emily - > > Another request... > > Description: > ========= > It would be nice to be able to programatically enable/disabled tabs in a > TabBar, preventing user's from selecting the tab. > > > Fix: > === > I added a TabBar.setTabEnabled(int index, boolean enabled) method and a > TabBar.isTabEnabled(int index) method. I added associated styles to the GWT > default style themes. There were a couple of questions about whether we > need a "disabled-and-selected" style, but I personally don't think its > necessary. We can always add it later if needed. > > Also note that this patch applies only to the TabBar, not to the TabPanel. > So users can programatically disable a tab in a TabBar, but it will not > disable the content of the assocaited TabPanel. The user must also > programatically boot the user off the tab if the app requires it. > > > Testing: > ======= > Manually verified the styles in IE versions of all browsers. Also added a > unit test to enable/disable the tabs. > > Thanks, > John LaBanca > [EMAIL PROTECTED] > -- "There are only 10 types of people in the world: Those who understand binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
