The old form generates less code, so yes we will want to revert it.
On Fri, Sep 19, 2008 at 11:16 PM, Freeland Abbott <
[EMAIL PROTECTED]> wrote:
> The patch LGTM, and I agree with John that this is an easy fix to an active
> problem, so I think that we should do it, even if we also go tweak the
> compiler later.
>
> If we assume the compiler fix arrives at some point---that is, that ("" +
> x) causes x.toString() to be rescued---is there any reason to prefer the old
> form to the new? If so, we shouldn't close the issue, and should not to
> undo this once the compiler rescue is done. (If not, I think this is
> harmless, and we wouldn't need to bother.)
>
>
> On Fri, Sep 19, 2008 at 8:51 PM, John Tamplin <[EMAIL PROTECTED]> wrote:
>
>> Given that people are running into this problem and the compiler fix does
>> not seem imminent, can someone review this patch as a temporary fix?
>>
>> --
>> John A. Tamplin
>> Software Engineer (GWT), Google
>>
>> >>
>>
>
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
