LGTM.
On Mon, Sep 22, 2008 at 11:39 AM, Freeland Abbott <
[EMAIL PROTECTED]> wrote:
> Turns out that "." is an unsound default directory for my <svninfo> task...
> works fine for normal human usage, but if you nest one Ant project (GWT) in
> another, even if that other sets basedir=..., it doesn't cd.
>
> So, we should get the project's basedir property instead; as it is, our
> last builds were branded with the svnversion of the builder's config file
> dir, not the project dir...
>
> Index: build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java
> ===================================================================
> --- build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java
> (revision 3670)
> +++ build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java
> (working copy)
> @@ -51,7 +51,7 @@
> "<svninfo> task requires an outputproperty attribute");
> }
> if (workdir == null) {
> - workdir = ".";
> + workdir = getProject().getProperty("basedir");
> }
> File workDirFile = new File(workdir);
> if (!workDirFile.isDirectory()) {
>
>
>
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
