Author: [EMAIL PROTECTED]
Date: Mon Sep 22 18:15:55 2008
New Revision: 3674

Modified:
    trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java
    trunk/common.ant.xml

Log:
Establish the working directory for <svninfo> more explicitly; it turns
out that "." is an unsound default (ant doesn't chdir).

Review by: scottb


Modified:  
trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java
==============================================================================
--- trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java      
 
(original)
+++ trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java      
 
Mon Sep 22 18:15:55 2008
@@ -51,7 +51,7 @@
            "<svninfo> task requires an outputproperty attribute");
      }
      if (workdir == null) {
-      workdir = ".";
+      workdir = getProject().getProperty("basedir");
      }
      File workDirFile = new File(workdir);
      if (!workDirFile.isDirectory()) {

Modified: trunk/common.ant.xml
==============================================================================
--- trunk/common.ant.xml        (original)
+++ trunk/common.ant.xml        Mon Sep 22 18:15:55 2008
@@ -204,7 +204,7 @@
        <taskdef name="svninfo"
           classname="com.google.gwt.ant.taskdefs.SvnInfo"
           classpath="${gwt.build.lib}/ant-gwt.jar" />
-      <svninfo outputproperty="gwt.svnrev"
+      <svninfo directory="${gwt.root}" outputproperty="gwt.svnrev"
            outputfileproperty="gwt.svnrev.filename" />
        <!-- Generally, filtering requires a sentinel file so that changes  
to svn rev will
           be noticed as invalidating the previously-generated filter  
output.  This property

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to