LGTM just a couple of nits below.
On Fri, Sep 5, 2008 at 1:52 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
>
> A
> samples/gadgetrpc/src/com/google/gwt/gadgets/sample/gadgetrpc/server/GadgetRPCServlet.java
>
Nit: Add @SuppressWarning("serial"). Did you intend to have the
servletStartTime field be static? Would instance final be better?
> A
> samples/gadgetrpc/src/com/google/gwt/gadgets/sample/gadgetrpc/client/ServerInfo.java
>
Nits: accessor methods? Add @SuppressWarning("serial")
> A
> samples/gadgetrpc/src/com/google/gwt/gadgets/sample/gadgetrpc/public/GadgetRPC.html
>
Nit: do you need this file?
> --
> Eric Z. Ayers - GWT Team - Atlanta, GA USA
> http://code.google.com/webtoolkit/
>
--
Miguel
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
