On Wed, Sep 24, 2008 at 1:51 PM, Joel Webber <[EMAIL PROTECTED]> wrote:
> I'd like you to have a look at the following changes to Safari's history > implementation. They're meant to work around the bizarre issues caused by > setting Safari's location.hash to an empty string. Please pay particular > attention to the ugly URL rewriting code I added to HistoryImplSafari. > I didn't bring my Macbook home with me so I can't test it -- I assume you have on both Safari 2 and 3. I assume no similar change was needed for Safari 2 since it already does something similar, right? You should update the comment in detectOldSafari since it is no longer accurate. Otherwise, LGTM. -- John A. Tamplin Software Engineer (GWT), Google --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
