Commited at 3699. On Thu, Oct 2, 2008 at 2:10 PM, John LaBanca <[EMAIL PROTECTED]> wrote:
> LGTM > > I'm not sure why I was setting the cellpadding and cellspacing to 0, but > thanks for fixing it. > > Thanks, > John LaBanca > [EMAIL PROTECTED] > > > > On Thu, Oct 2, 2008 at 11:58 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > >> John, >> >> In what turns out to be one heck of a coninsidence, bug *28*53 was caused >> by the patch to bug *25*53. >> >> Removing half the fix for 2553 seems to fix the problem and preserve the >> fix for 2553, though if you know of additional tests you did for 2553 that >> would be great, as I've used only the one from the initial bug report. >> >> Included in the patch is >> >> - a code musuem issue for 2553 to test that it was still working. >> - the patch to tree item. >> - a new TreeVisuals code case for basic tree validation. >> >> Thanks for the code review and for spotting the bug, as it is definitely >> a good one to get out of the system! >> >> Cheers, >> >> Emily >> >> >> >> >> >> >> -- >> "There are only 10 types of people in the world: Those who understand >> binary, and those who don't" >> > > -- "There are only 10 types of people in the world: Those who understand binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
