The format for gwt.svnrev is [EMAIL PROTECTED], and if a real answer can't
be determined it's set to "[EMAIL PROTECTED]," so I'd rather keep that pattern
consistent instead of the "0" here.
As a bigger change, though, I'd actually suggest pushing the test for .svn
into SvnInfo.java; that already handles error conditions like the svn or
svnversion binaries not being available, so it's a reasonable fit to check
for workspace configuration there, and it makes the build file itself
cleaner.

General concept is fine, of course, but can we make those changes?



On Fri, Oct 3, 2008 at 8:28 PM, Scott Blum <[EMAIL PROTECTED]> wrote:

> Freeland, it's all you. :)
>
> On Fri, Oct 3, 2008 at 8:23 PM, Mike Aizatsky <[EMAIL PROTECTED]>wrote:
>
>> Hi!
>>
>> I've fixed build file to support working in non-svn workdir (e.g. git
>> :). Can you please get this in?
>>
>> --
>> Regards,
>> Mike
>>
>
>

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to