Hi Mike,
I'm really glad you broke ground on this.  I took a look, but wanted to ask
a question or two and give some high-level feedback before I dig in too
much.

- Could briefly summarize the motivation for the
suite()/JJSOptimizerTestDecator design?

- JJSOptimizerTestCase.staticJprogram strikes me as scary.. is this
necessary?

- Textual comparison seems like a great first step, but a bit brittle going
forward.  I'd worry that changes in the compiler totally unrelated to an
optimization pass would tend to unnecessarily break tests.

- Noticed many issues with things like sort order, formatting, spelling.
 Have you looked at the GWT eclipse
setup<http://code.google.com/p/google-web-toolkit/source/browse/trunk/eclipse/README.txt>
?

- Very high-level: We should talk about doing something more invasive to
make testing lighter weight.  There's really no reason to have to setup a
GWT module to do a test... with some refactoring we could make it as easy as
providing some input source and some output source.

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to