That seems like a reasonable approach.. it was always a bit weird to have a method with no containing class. I'd look at com.google.gwt.lang.ClassLiteralHolder as a template for this idea. In fact, you might be able to get rid of JProgram.entryMethods in favor of an entry class.
On Mon, Oct 6, 2008 at 6:53 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > On Mon, Oct 6, 2008 at 4:20 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > > How do you clean up dead refs in the entry method, which isn't part of > any > > class? > > Good catch. It sounds like there is a more fundamental problem. > > The runAsync entry methods actually are included in a class. Thus, in > some circumstances I saw these methods get cleaned twice and thus > ending up with invalid method calls. Since the normal entry method is > not part of a class, there's no simple solution for Pruner to do its > cleaning up. > > To make the story consistent, what would you think of attaching the > existing entry method to some class? The other arrangement looks > awkward, because the runAsync entry methods are the result of > generator runs. They're plain old static methods. > > -Lex > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
