Fixed whitespace issue - Thanks. Committed as r877. On Fri, Oct 10, 2008 at 9:41 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote: > That was the problem. LGTM with one nit: ResourceStoreDemo line 41 has some > additional whitespace. > > Nice cleanup. > On Fri, Oct 10, 2008 at 9:32 AM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >> I didn't mention that this patch was against the releases/gears/1.1 >> branch - could that have been the problem? >> >> I just created a new diff on my Linux box and it looks slightly >> different (attached). Would you mind giving that one a try (r875) >> >> On Fri, Oct 10, 2008 at 9:24 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote: >> > The patch did not apply cleanly against r874. Was that the revision >> > against >> > which the patch was built? Here is the output: >> > >> > Hunk #3 FAILED at 85. >> > 1 out of 6 hunks FAILED -- saving rejects to file >> > >> > samples/resourcestore/src/com/google/gwt/gears/sample/resourcestore/client/ResourceStoreDemo.java.rej >> > >> > The *.orig and *.rej files are attached. >> > On Thu, Oct 9, 2008 at 2:54 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >> >> >> Hello Miguel, >> >> >> >> I'd like for you to review the attached patch (& screenshot) >> >> >> >> It changes the layout of the demo just a bit to put some margin around >> >> the outside. >> >> It also adds code to toggle the enable/disable state of the buttons to >> >> match the user's actions. >> >> >> >> M >> >> >> >> >> >> samples/resourcestore/src/com/google/gwt/gears/sample/resourcestore/client/ResourceStoreDemo.java >> >> M >> >> >> >> >> >> samples/resourcestore/src/com/google/gwt/gears/sample/resourcestore/public/ResourceStoreDemo.html >> >> >> >> -Eric. >> >> -- >> >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> >> http://code.google.com/webtoolkit/ >> > >> > >> > >> > -- >> > Miguel >> > >> >> >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ > > > > -- > Miguel >
-- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
