On Wed, Oct 15, 2008 at 2:47 AM, Katharina Probst <[EMAIL PROTECTED]>wrote:
> I would say yes to the equals and compareTo, but I wouldn't consider the > hashCode a blocking issue (although it's the simplest fix...). > > The equals and compareTo have the potential to create information loss (for > example, something not added to the ancestor list) if there are actually > cases where the comparison does not return the correct result. [In other > words, the question is, can the current comparison in theory return a wrong > result or is it provably correct?] > I agree. Bob, what do you think? There are cases where addAdditionalAncestor will not actually add the ancestor. The question Kathrin and I could not answer is whether any of those cases matter. -Lex --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
