At first glance, I don't see the need for a public TabWrapper interface. Can you tell me what the use case is for this? My main concerns are the following: 1. Its more API clutter 2. Can't users just add listeners directly to their widgets that they put into the tabs? 3. We have a lot of widgets that "wrap" content. Will they all have wrappers? 4. I think this is too implementation specific to make public. The fact that we wrap tabs in a ClickDecoratorPanel so we can catch events and style them is just an implementation. We could just as easily (well, not as easily) catch events on the outer element and determine where the event occured.
But, since you obviously thought this out, I'm sure I'm missing some key point. Thanks, John LaBanca [EMAIL PROTECTED] On Mon, Nov 10, 2008 at 8:16 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > (Reviving the old Response Requested meaning of RR--there is no patch here, > but rather a design question.) > > Take a look at the new TabWrapper getTabWrapper(int index) method on > TabBar in the 1_6_clean_events branch: > > > http://code.google.com/p/google-web-toolkit/source/browse/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java > > See that interface it returns, TabWrapper extends HasAllKeyHandlers, > HasClickHandlers? Emily and I would like to make that more useful without > necessarily committing to it being a Widget. > To that end, we'd like to introduce a new interface, HasElement, which will > hold most or all of the public API of UIObject. We'd make similar use of the > interface for DialogBox#getCaptionWrapper(), and one or two other places > that I hope Emily will remind me of. > > Any objections or warnings before we go ahead and make the change? > > rjrjr > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
