Author: [EMAIL PROTECTED]
Date: Tue Nov 11 12:41:10 2008
New Revision: 4018
Added:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodes.java
(contents, props changed)
- copied, changed from r4000,
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasKeyCodes.java
Removed:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasKeyCodes.java
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForEventsFiring.java
branches/1_6_clean_events/samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.java
branches/1_6_clean_events/samples/showcase/src/com/google/gwt/sample/showcase/client/content/other/CwFrame.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodeEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownHandler.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpHandler.java
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseEvent.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/L.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/MenuBar.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Tree.java
Log:
Removed HasKeyCodes interface, instead now we want uses who were inheriting
constants from KeyboardListener to statically import KeyCodes instead.
Punting on enum issue by removing the buttons from MouseEvent altogether
and renaming both getKeyCode and getButton
Modified:
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForEventsFiring.java
==============================================================================
---
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForEventsFiring.java
(original)
+++
branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForEventsFiring.java
Tue Nov 11 12:41:10 2008
@@ -147,13 +147,13 @@
});
button.addMouseDownHandler(new MouseDownHandler() {
public void onMouseDown(MouseDownEvent event) {
- event.getButton();
+ event.getNativeButton();
passTest(event.getNativeEvent());
}
});
button.addMouseUpHandler(new MouseUpHandler() {
public void onMouseUp(MouseUpEvent event) {
- event.getButton();
+ event.getNativeButton();
passTest(event.getNativeEvent());
}
});
@@ -200,7 +200,7 @@
event.isControlKeyDown();
event.isShiftKeyDown();
event.isMetaKeyDown();
- assert event.getKeyCode() > 0;
+ assert event.getNativeKeyCode() > 0;
passTest(event.getNativeEvent());
}
});
@@ -210,7 +210,7 @@
event.isControlKeyDown();
event.isShiftKeyDown();
event.isMetaKeyDown();
- assert event.getKeyCode() > 0;
+ assert event.getNativeKeyCode() > 0;
passTest(event.getNativeEvent());
}
});
Modified:
branches/1_6_clean_events/samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.java
==============================================================================
---
branches/1_6_clean_events/samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.java
(original)
+++
branches/1_6_clean_events/samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.java
Tue Nov 11 12:41:10 2008
@@ -17,7 +17,7 @@
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
-import com.google.gwt.event.dom.client.HasKeyCodes;
+import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.DialogBox;
import com.google.gwt.user.client.ui.HTML;
@@ -60,8 +60,8 @@
// Use the popup's key preview hooks to close the dialog when either
// enter or escape is pressed.
switch (key) {
- case HasKeyCodes.KEY_ENTER:
- case HasKeyCodes.KEY_ESCAPE:
+ case KeyCodes.KEY_ENTER:
+ case KeyCodes.KEY_ESCAPE:
hide();
break;
}
Modified:
branches/1_6_clean_events/samples/showcase/src/com/google/gwt/sample/showcase/client/content/other/CwFrame.java
==============================================================================
---
branches/1_6_clean_events/samples/showcase/src/com/google/gwt/sample/showcase/client/content/other/CwFrame.java
(original)
+++
branches/1_6_clean_events/samples/showcase/src/com/google/gwt/sample/showcase/client/content/other/CwFrame.java
Tue Nov 11 12:41:10 2008
@@ -18,6 +18,7 @@
import com.google.gwt.core.client.GWT;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyDownEvent;
import com.google.gwt.event.dom.client.KeyDownHandler;
import com.google.gwt.i18n.client.Constants;
@@ -110,7 +111,7 @@
// Change the location when the user presses enter
locationBox.addKeyDownHandler(new KeyDownHandler() {
public void onKeyDown(KeyDownEvent event) {
- if (event.getKeyCode() == KEY_ENTER) {
+ if (event.getNativeKeyCode() == KeyCodes.KEY_ENTER) {
frame.setUrl(locationBox.getText());
}
}
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodeEvent.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodeEvent.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodeEvent.java
Tue Nov 11 12:41:10 2008
@@ -23,8 +23,7 @@
*
* @param <H> handler type
*/
-public abstract class KeyCodeEvent<H extends EventHandler> extends
KeyEvent<H>
- implements HasKeyCodes {
+public abstract class KeyCodeEvent<H extends EventHandler> extends
KeyEvent<H> {
/**
* Does the key code represent an arrow key?
*
@@ -33,10 +32,10 @@
*/
public static boolean isArrow(int keyCode) {
switch (keyCode) {
- case KEY_DOWN:
- case KEY_RIGHT:
- case KEY_UP:
- case KEY_LEFT:
+ case KeyCodes.KEY_DOWN:
+ case KeyCodes.KEY_RIGHT:
+ case KeyCodes.KEY_UP:
+ case KeyCodes.KEY_LEFT:
return true;
default:
return false;
@@ -44,11 +43,12 @@
}
/**
- * Gets the current key code.
+ * Gets the native key code. These key codes are enumerated in the
+ * [EMAIL PROTECTED] KeyCodes} class.
*
* @return the key code
*/
- public int getKeyCode() {
+ public int getNativeKeyCode() {
return getNativeEvent().getKeyCode();
}
@@ -58,7 +58,7 @@
* @return is the key code alpha numeric.
*/
public boolean isAlphaNumeric() {
- final int keycode = getKeyCode();
+ final int keycode = getNativeKeyCode();
return (48 <= keycode && keycode <= 57) || (65 <= keycode && keycode
<= 90);
}
@@ -68,7 +68,7 @@
* @return whether this is a down arrow key event
*/
public boolean isDownArrow() {
- return getKeyCode() == KEY_DOWN;
+ return getNativeKeyCode() == KeyCodes.KEY_DOWN;
}
/**
@@ -77,7 +77,7 @@
* @return whether this is a left arrow key event
*/
public boolean isLeftArrow() {
- return getKeyCode() == KEY_LEFT;
+ return getNativeKeyCode() == KeyCodes.KEY_LEFT;
}
/**
@@ -86,7 +86,7 @@
* @return whether this is a right arrow key event
*/
public boolean isRightArrow() {
- return getKeyCode() == KEY_RIGHT;
+ return getNativeKeyCode() == KeyCodes.KEY_RIGHT;
}
/**
@@ -95,12 +95,12 @@
* @return whether this is a right arrow key event
*/
public boolean isUpArrow() {
- return getKeyCode() == KEY_UP;
+ return getNativeKeyCode() == KeyCodes.KEY_UP;
}
@Override
public String toDebugString() {
- return super.toDebugString() + "[" + getKeyCode() + "]";
+ return super.toDebugString() + "[" + getNativeKeyCode() + "]";
}
}
Copied:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodes.java
(from r4000,
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasKeyCodes.java)
==============================================================================
---
/branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HasKeyCodes.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyCodes.java
Tue Nov 11 12:41:10 2008
@@ -17,87 +17,91 @@
package com.google.gwt.event.dom.client;
/**
- * Adapting from [EMAIL PROTECTED]
com.google.gwt.user.client.ui.KeyboardListener}.
Without
- * this interface the migration headache from keyboard listeners to key
handlers
- * becomes a pain, as almost all current listeners use the short form
- * <codE>KEY_ALT</code> when referring to key codes.
+ * Contains the native key codes previously defined in
+ * [EMAIL PROTECTED] com.google.gwt.user.client.ui.KeyboardListener}. When
converting
+ * keyboard listener instances, developers can use the following static
import
+ * to access these constants:
+ *
+ * <pre> import static com.google.gwt.event.dom.client.KeyCodes.*; </pre>
+ *
+ * These constants are defined with an int data type in order to be
compatible
+ * with the constants defined in
+ * [EMAIL PROTECTED] com.google.gwt.user.client.ui.KeyboardListener}.
*/
-
-// Need to have a team discussion to decide if we want this pattern in
general.
-// Until then, just turning checkstyle off.
-// CHECKSTYLE_OFF
[EMAIL PROTECTED]("all")
-public interface HasKeyCodes {
+public class KeyCodes {
/**
* Alt key code.
*/
- int KEY_ALT = 18;
+ public static final int KEY_ALT = 18;
/**
* Backspace key code.
*/
- int KEY_BACKSPACE = 8;
-
+ public static final int KEY_BACKSPACE = 8;
/**
* Control key code.
*/
- int KEY_CTRL = 17;
+ public static final int KEY_CTRL = 17;
/**
* Delete key code.
*/
- int KEY_DELETE = 46;
+ public static final int KEY_DELETE = 46;
/**
* Down arrow code.
*/
- int KEY_DOWN = 40;
+ public static final int KEY_DOWN = 40;
/**
* End key code.
*/
- int KEY_END = 35;
+ public static final int KEY_END = 35;
+
/**
* Enter key code.
*/
- int KEY_ENTER = 13;
+ public static final int KEY_ENTER = 13;
/**
* Escape key code.
*/
- int KEY_ESCAPE = 27;
+ public static final int KEY_ESCAPE = 27;
/**
* Home key code.
*/
- int KEY_HOME = 36;
+ public static final int KEY_HOME = 36;
/**
* Left key code.
*/
- int KEY_LEFT = 37;
+ public static final int KEY_LEFT = 37;
/**
* Page down key code.
*/
- int KEY_PAGEDOWN = 34;
+ public static final int KEY_PAGEDOWN = 34;
/**
* Page up key code.
*/
- int KEY_PAGEUP = 33;
+ public static final int KEY_PAGEUP = 33;
/**
* Right arrow key code.
*/
- int KEY_RIGHT = 39;
-
+ public static final int KEY_RIGHT = 39;
/**
* Shift key code.
*/
- int KEY_SHIFT = 16;
+ public static final int KEY_SHIFT = 16;
+
/**
* Tab key code.
*/
- int KEY_TAB = 9;
-
+ public static final int KEY_TAB = 9;
/**
* Up Arrow key code.
*/
- int KEY_UP = 38;
+ public static final int KEY_UP = 38;
+
+ // This class should never be instantiated
+ private KeyCodes() {
+ }
}
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownHandler.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownHandler.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownHandler.java
Tue Nov 11 12:41:10 2008
@@ -20,7 +20,7 @@
/**
* Handler interface for [EMAIL PROTECTED] KeyDownEvent} events.
*/
-public interface KeyDownHandler extends EventHandler, HasKeyCodes {
+public interface KeyDownHandler extends EventHandler {
/**
* Called when [EMAIL PROTECTED] KeyDownEvent} is fired.
*
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpHandler.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpHandler.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpHandler.java
Tue Nov 11 12:41:10 2008
@@ -20,7 +20,7 @@
/**
* Handler interface for [EMAIL PROTECTED] KeyUpEvent} events.
*/
-public interface KeyUpHandler extends EventHandler, HasKeyCodes {
+public interface KeyUpHandler extends EventHandler {
/**
* Called when KeyUpEvent is fired.
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseEvent.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseEvent.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseEvent.java
Tue Nov 11 12:41:10 2008
@@ -27,22 +27,6 @@
*
*/
public abstract class MouseEvent<H extends EventHandler> extends
DomEvent<H> {
-
- /**
- * Left mouse button down.
- */
- public static final int BUTTON_LEFT = Event.BUTTON_LEFT;
-
- /**
- * Right mouse button down.
- */
- public static final int BUTTON_RIGHT = Event.BUTTON_RIGHT;
-
- /**
- * Middle button down.
- */
- public static final int BUTTON_MIDDLE = Event.BUTTON_MIDDLE;
-
/**
* Gets the x coordinate relative to the given element.
*
@@ -68,16 +52,6 @@
}
/**
- * Gets the button value. Compare it to [EMAIL PROTECTED]
MouseEvent#BUTTON_LEFT},
- * [EMAIL PROTECTED] MouseEvent#BUTTON_RIGHT}, [EMAIL PROTECTED]
MouseEvent#BUTTON_MIDDLE}
- *
- * @return gets the button value.
- */
- public int getButton() {
- return getNativeEvent().getButton();
- }
-
- /**
* Gets the mouse x-position within the browser window's client area.
*
* @return the mouse x-position
@@ -93,6 +67,16 @@
*/
public int getClientY() {
return getNativeEvent().getClientY();
+ }
+
+ /**
+ * Gets the button value. Compare it to [EMAIL PROTECTED] Event#BUTTON_LEFT},
+ * [EMAIL PROTECTED] Event#BUTTON_RIGHT}, [EMAIL PROTECTED]
Event#BUTTON_MIDDLE}
+ *
+ * @return the button value
+ */
+ public int getNativeButton() {
+ return getNativeEvent().getButton();
}
/**
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/L.java
==============================================================================
--- branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/L.java
(original)
+++ branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/L.java
Tue Nov 11 12:41:10 2008
@@ -486,7 +486,7 @@
}
public void onKeyDown(KeyDownEvent event) {
- listener.onKeyDown(source(event), (char) event.getKeyCode(),
+ listener.onKeyDown(source(event), (char) event.getNativeKeyCode(),
event.getKeyModifiers());
}
@@ -497,7 +497,7 @@
public void onKeyUp(KeyUpEvent event) {
source(event);
- listener.onKeyUp(source(event), (char) event.getKeyCode(),
+ listener.onKeyUp(source(event), (char) event.getNativeKeyCode(),
event.getKeyModifiers());
}
}
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/MenuBar.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/MenuBar.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/MenuBar.java
Tue Nov 11 12:41:10 2008
@@ -16,7 +16,7 @@
package com.google.gwt.user.client.ui;
import com.google.gwt.core.client.GWT;
-import com.google.gwt.event.dom.client.KeyCodeEvent;
+import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.logical.shared.CloseEvent;
import com.google.gwt.event.logical.shared.CloseHandler;
import com.google.gwt.event.logical.shared.HasCloseHandlers;
@@ -431,7 +431,7 @@
case Event.ONKEYDOWN: {
int keyCode = DOM.eventGetKeyCode(event);
switch (keyCode) {
- case KeyCodeEvent.KEY_LEFT:
+ case KeyCodes.KEY_LEFT:
if (LocaleInfo.getCurrentLocale().isRTL()) {
moveToNextItem();
} else {
@@ -439,7 +439,7 @@
}
eatEvent(event);
break;
- case KeyCodeEvent.KEY_RIGHT:
+ case KeyCodes.KEY_RIGHT:
if (LocaleInfo.getCurrentLocale().isRTL()) {
moveToPrevItem();
} else {
@@ -447,19 +447,19 @@
}
eatEvent(event);
break;
- case KeyCodeEvent.KEY_UP:
+ case KeyCodes.KEY_UP:
moveUp();
eatEvent(event);
break;
- case KeyCodeEvent.KEY_DOWN:
+ case KeyCodes.KEY_DOWN:
moveDown();
eatEvent(event);
break;
- case KeyCodeEvent.KEY_ESCAPE:
+ case KeyCodes.KEY_ESCAPE:
closeAllParents();
eatEvent(event);
break;
- case KeyCodeEvent.KEY_ENTER:
+ case KeyCodes.KEY_ENTER:
if (!selectFirstItemIfNoneSelected()) {
doItemAction(selectedItem, true);
eatEvent(event);
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/SuggestBox.java
Tue Nov 11 12:41:10 2008
@@ -15,6 +15,11 @@
*/
package com.google.gwt.user.client.ui;
+import static com.google.gwt.event.dom.client.KeyCodes.KEY_DOWN;
+import static com.google.gwt.event.dom.client.KeyCodes.KEY_ENTER;
+import static com.google.gwt.event.dom.client.KeyCodes.KEY_TAB;
+import static com.google.gwt.event.dom.client.KeyCodes.KEY_UP;
+
import com.google.gwt.event.dom.client.HandlesAllKeyEvents;
import com.google.gwt.event.dom.client.HasAllKeyHandlers;
import com.google.gwt.event.dom.client.KeyDownEvent;
@@ -41,7 +46,6 @@
import java.util.Collection;
import java.util.List;
-
/**
* A [EMAIL PROTECTED] SuggestBox} is a text box or text area which displays a
* pre-configured set of selections that match the user's input.
@@ -699,7 +703,7 @@
// Make sure that the menu is actually showing. These keystrokes
// are only relevant when choosing a suggestion.
if (suggestionPopup.isAttached()) {
- switch (event.getKeyCode()) {
+ switch (event.getNativeKeyCode()) {
case KEY_DOWN:
suggestionMenu.selectItem(suggestionMenu.getSelectedItemIndex() + 1);
break;
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
Tue Nov 11 12:41:10 2008
@@ -19,7 +19,7 @@
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.HasAllKeyHandlers;
import com.google.gwt.event.dom.client.HasClickHandlers;
-import com.google.gwt.event.dom.client.HasKeyCodes;
+import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyDownEvent;
import com.google.gwt.event.dom.client.KeyDownHandler;
import com.google.gwt.event.dom.client.KeyEvent;
@@ -145,7 +145,7 @@
break;
case Event.ONKEYDOWN:
- if (((char) DOM.eventGetKeyCode(event)) ==
HasKeyCodes.KEY_ENTER) {
+ if (((char) DOM.eventGetKeyCode(event)) == KeyCodes.KEY_ENTER) {
TabBar.this.selectTabByTabWidget(this);
}
TabBar.this.onKeyDown(this, (char) event.getKeyCode(),
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Tree.java
==============================================================================
---
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Tree.java
(original)
+++
branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/Tree.java
Tue Nov 11 12:41:10 2008
@@ -23,7 +23,7 @@
import com.google.gwt.event.dom.client.HasAllFocusHandlers;
import com.google.gwt.event.dom.client.HasAllKeyHandlers;
import com.google.gwt.event.dom.client.HasAllMouseHandlers;
-import com.google.gwt.event.dom.client.HasKeyCodes;
+import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyDownEvent;
import com.google.gwt.event.dom.client.KeyDownHandler;
import com.google.gwt.event.dom.client.KeyPressEvent;
@@ -183,10 +183,10 @@
case OTHER_KEY_RIGHT:
case OTHER_KEY_UP:
case OTHER_KEY_LEFT:
- case HasKeyCodes.KEY_DOWN:
- case HasKeyCodes.KEY_RIGHT:
- case HasKeyCodes.KEY_UP:
- case HasKeyCodes.KEY_LEFT:
+ case KeyCodes.KEY_DOWN:
+ case KeyCodes.KEY_RIGHT:
+ case KeyCodes.KEY_UP:
+ case KeyCodes.KEY_LEFT:
return true;
default:
return false;
@@ -200,23 +200,23 @@
private static int standardizeKeycode(int code) {
switch (code) {
case OTHER_KEY_DOWN:
- code = HasKeyCodes.KEY_DOWN;
+ code = KeyCodes.KEY_DOWN;
break;
case OTHER_KEY_RIGHT:
- code = HasKeyCodes.KEY_RIGHT;
+ code = KeyCodes.KEY_RIGHT;
break;
case OTHER_KEY_UP:
- code = HasKeyCodes.KEY_UP;
+ code = KeyCodes.KEY_UP;
break;
case OTHER_KEY_LEFT:
- code = HasKeyCodes.KEY_LEFT;
+ code = KeyCodes.KEY_LEFT;
break;
}
if (LocaleInfo.getCurrentLocale().isRTL()) {
- if (code == HasKeyCodes.KEY_RIGHT) {
- code = HasKeyCodes.KEY_LEFT;
- } else if (code == HasKeyCodes.KEY_LEFT) {
- code = HasKeyCodes.KEY_RIGHT;
+ if (code == KeyCodes.KEY_RIGHT) {
+ code = KeyCodes.KEY_LEFT;
+ } else if (code == KeyCodes.KEY_LEFT) {
+ code = KeyCodes.KEY_RIGHT;
}
}
return code;
@@ -547,7 +547,7 @@
}
case Event.ONKEYUP: {
- if (DOM.eventGetKeyCode(event) == HasKeyCodes.KEY_TAB) {
+ if (DOM.eventGetKeyCode(event) == KeyCodes.KEY_TAB) {
ArrayList<Element> chain = new ArrayList<Element>();
collectElementChain(chain, getElement(),
DOM.eventGetTarget(event));
TreeItem item = findItemByChain(chain, 0, root);
@@ -1000,19 +1000,19 @@
int code = DOM.eventGetKeyCode(event);
switch (standardizeKeycode(code)) {
- case HasKeyCodes.KEY_UP: {
+ case KeyCodes.KEY_UP: {
moveSelectionUp(curSelection);
break;
}
- case HasKeyCodes.KEY_DOWN: {
+ case KeyCodes.KEY_DOWN: {
moveSelectionDown(curSelection, true);
break;
}
- case HasKeyCodes.KEY_LEFT: {
+ case KeyCodes.KEY_LEFT: {
maybeCollapseTreeItem();
break;
}
- case HasKeyCodes.KEY_RIGHT: {
+ case KeyCodes.KEY_RIGHT: {
maybeExpandTreeItem();
break;
}
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
