Was this review directed at a different revision? Project Hosting error or user error?
On Tue, Nov 11, 2008 at 6:11 PM, <[EMAIL PROTECTED]> wrote: > > [google-web-toolkit] [EMAIL PROTECTED] commented on revision r4022. > Details are at > http://code.google.com/p/google-web-toolkit/source/detail?r=4022 > > Score: Neutral > > General Comment: > See the one inline comment. Two other comments: > - projectCreator currently doesn't run; it should be removed from the > distro if we're going to get rid of it > - Please review the descriptions on the command-line switches for > consitency; the only thing I saw off the bat was inconsistent use of > periods (we traditional do not use periods in this context) > > Line-by-line comments: > > File: > /releases/1.6/user/src/com/google/gwt/user/tools/ApplicationCreator.java > (r4004) > > =============================================================================== > > Line 552: return "Specifies the deploy directory (defaults to > deployDir)"; > > ------------------------------------------------------------------------------- > Shouldn't the parenthetical comment be "defaults to 'war'"? > > Respond to these comments at > http://code.google.com/p/google-web-toolkit/source/detail?r=4022 > -- > You received this message because you starred this review, or because > your project has directed all notifications to a mailing list that you > subscribe to. > You may adjust your review notification preferences at: > http://code.google.com/hosting/settings > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
