[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4034.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4034
General Comment:
I'd like the final on getTab() to go away, or else to see vergiage in the
javadoc defending it.
Line-by-line comments:
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
(r4034)
===============================================================================
Line 78: public DialogBox.Caption getCaption() {
-------------------------------------------------------------------------------
Why?
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
(r4034)
===============================================================================
Line 256: public final Tab getTab(int index) {
-------------------------------------------------------------------------------
Why is this final? Let's try to get into the habit of documenting our
reasoning whenever we do this.
Line 355: public void onClick(Widget sender) {
-------------------------------------------------------------------------------
Missing @Deprecated annotation
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4034
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
