[google-web-toolkit] kellegous commented on revision r4045.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4045
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
(r4045)
===============================================================================
Line 75: if (!result) {
-------------------------------------------------------------------------------
From the GWT standpoint, this really should be an assertion. I can't think
of any legitmate use of catching IllegalArgException at runtime. If we're
going to take on supporting this code on the server side, I think we have
to either require assertions on the server or we have to use
GWT.isClient/isScript to throw exceptions in pure java and depend on
assertions in GWT code.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4045
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
