Author: [EMAIL PROTECTED]
Date: Thu Nov 13 08:31:02 2008
New Revision: 4046

Removed:
     
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerAdaptor.java
Modified:
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/BlurEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ChangeEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ContextMenuEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DoubleClickEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ErrorEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/FocusEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyPressEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoadEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoseCaptureEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseDownEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseMoveEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOutEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOverEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseUpEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ScrollEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/CloseEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/OpenEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/SelectionEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java
     
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java
     
branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java

Log:
Making javadoc tweaks and removing HandlerAdaptor as unused now.

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/BlurEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/BlurEvent.java
        
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/BlurEvent.java
        
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire blur events.
     */
    protected BlurEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ChangeEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ChangeEvent.java
      
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ChangeEvent.java
      
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire change events.
     */
    protected ChangeEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ContextMenuEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ContextMenuEvent.java
         
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ContextMenuEvent.java
         
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire context menu events.
     */
    protected ContextMenuEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DoubleClickEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DoubleClickEvent.java
         
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DoubleClickEvent.java
         
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire double click events.
     */
    protected DoubleClickEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ErrorEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ErrorEvent.java
       
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ErrorEvent.java
       
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire error events.
     */
    protected ErrorEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/FocusEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/FocusEvent.java
       
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/FocusEvent.java
       
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire focus events.
     */
    protected FocusEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownEvent.java
     
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyDownEvent.java
     
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire key down events.
     */
    protected KeyDownEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyEvent.java
         
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyEvent.java
         
Thu Nov 13 08:31:02 2008
@@ -24,7 +24,7 @@
   * (http://www.quirksmode.org/js/keys.html), we do some trivial  
normalization
   * here, but do not attempt any complex patching, so user be warned.
   *
- * @param <H>
+ * @param <H> The event handler type
   */
  public abstract class KeyEvent<H extends EventHandler> extends DomEvent<H>  
{


Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyPressEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyPressEvent.java
    
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyPressEvent.java
    
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire key press events.
     */
    protected KeyPressEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpEvent.java
       
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/KeyUpEvent.java
       
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire key up events.
     */
    protected KeyUpEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoadEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoadEvent.java
        
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoadEvent.java
        
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire load events.
     */
    protected LoadEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoseCaptureEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoseCaptureEvent.java
         
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/LoseCaptureEvent.java
         
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire lose capture events.
     */
    protected LoseCaptureEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseDownEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseDownEvent.java
   
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseDownEvent.java
   
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire mouse down events.
     */
    protected MouseDownEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseMoveEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseMoveEvent.java
   
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseMoveEvent.java
   
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire mouse move events.
     */
    protected MouseMoveEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOutEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOutEvent.java
    
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOutEvent.java
    
Thu Nov 13 08:31:02 2008
@@ -41,7 +41,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire mouse out events.
     */
    protected MouseOutEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOverEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOverEvent.java
   
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseOverEvent.java
   
Thu Nov 13 08:31:02 2008
@@ -41,7 +41,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire mouse over events.
     */
    protected MouseOverEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseUpEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseUpEvent.java
     
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseUpEvent.java
     
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire mouse up events.
     */
    protected MouseUpEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
  
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
  
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire mouse wheel events.
     */
    protected MouseWheelEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ScrollEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ScrollEvent.java
      
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/ScrollEvent.java
      
Thu Nov 13 08:31:02 2008
@@ -40,7 +40,7 @@

    /**
     * Protected constructor, use
-   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)
+   * [EMAIL PROTECTED] DomEvent#fireNativeEvent(Event,  
com.google.gwt.event.shared.HandlerManager)}
     * to fire scroll events.
     */
    protected ScrollEvent() {

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/CloseEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/CloseEvent.java
   
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/CloseEvent.java
   
Thu Nov 13 08:31:02 2008
@@ -31,39 +31,37 @@
    private static Type<CloseHandler<?>> TYPE;

    /**
-   * Fires a close event on all registered handlers in the handler manager.
+   * Fires a close event on all registered handlers in the handler  
manager. If
+   * no such handlers exist, this method will do nothing.
     *
     * @param <T> the target type
     * @param <S> The event source
     * @param source the source of the handlers
     * @param target the target
-   * @param autoClosed was the target closed automatically
     */
    public static <T, S extends HasCloseHandlers<T> & HasHandlers> void fire(
-      S source, T target, boolean autoClosed) {
-    if (TYPE != null) {
-      HandlerManager handlers = source.getHandlers();
-      if (handlers != null) {
-        CloseEvent<T> event = new CloseEvent<T>();
-        event.autoClosed = autoClosed;
-        event.setTarget(target);
-        handlers.fireEvent(event);
-      }
-    }
+      S source, T target) {
+    fire(source, target, false);
    }

    /**
-   * Fires a close event on all registered handlers in the handler  
manager. If
-   * no such handlers exist, this method will do nothing.
+   * Fires a close event on all registered handlers in the handler manager.
     *
     * @param <T> the target type
     * @param <S> The event source
     * @param source the source of the handlers
     * @param target the target
+   * @param autoClosed was the target closed automatically
     */
    public static <T, S extends HasCloseHandlers<T> & HasHandlers> void fire(
-      S source, T target) {
-    fire(source, target, false);
+      S source, T target, boolean autoClosed) {
+    if (TYPE != null) {
+      HandlerManager handlers = source.getHandlers();
+      if (handlers != null) {
+        CloseEvent<T> event = new CloseEvent<T>(target, autoClosed);
+        handlers.fireEvent(event);
+      }
+    }
    }

    /**
@@ -75,14 +73,19 @@
      return TYPE != null ? TYPE : (TYPE = new Type<CloseHandler<?>>());
    }

-  private T target;
+  private final T target;

-  private boolean autoClosed;
+  private final boolean autoClosed;

    /**
     * Creates a new close event.
+   *
+   * @param target the target
+   * @param autoClosed whether it is auto closed
     */
-  protected CloseEvent() {
+  protected CloseEvent(T target, boolean autoClosed) {
+    this.autoClosed = autoClosed;
+    this.target = target;
    }

    /**
@@ -115,23 +118,5 @@
    @Override
    protected final Type<CloseHandler<T>> getAssociatedType() {
      return (Type) TYPE;
-  }
-
-  /**
-   * Was the target automatically closed?
-   *
-   * @param autoClosed autoClosed
-   */
-  protected final void setAutoClosed(boolean autoClosed) {
-    this.autoClosed = autoClosed;
-  }
-
-  /**
-   * Sets the target.
-   *
-   * @param target the target
-   */
-  protected final void setTarget(T target) {
-    this.target = target;
    }
  }

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/OpenEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/OpenEvent.java
    
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/OpenEvent.java
    
Thu Nov 13 08:31:02 2008
@@ -44,8 +44,7 @@
      if (TYPE != null) {
        HandlerManager handlers = source.getHandlers();
        if (handlers != null) {
-        OpenEvent<T> event = new OpenEvent<T>();
-        event.setTarget(target);
+        OpenEvent<T> event = new OpenEvent<T>(target);
          handlers.fireEvent(event);
        }
      }
@@ -63,12 +62,15 @@
      return TYPE;
    }

-  private T target;
+  private final T target;

    /**
     * Creates a new open event.
+   *
+   * @param target the ui object being opened
     */
-  protected OpenEvent() {
+  protected OpenEvent(T target) {
+    this.target = target;
    }

    /**
@@ -92,14 +94,5 @@
    @Override
    protected final Type<OpenHandler<T>> getAssociatedType() {
      return (Type) TYPE;
-  }
-
-  /**
-   * Sets the target.
-   *
-   * @param target the target
-   */
-  protected final void setTarget(T target) {
-    this.target = target;
    }
  }

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/SelectionEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/SelectionEvent.java
       
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/SelectionEvent.java
       
Thu Nov 13 08:31:02 2008
@@ -44,8 +44,7 @@
      if (TYPE != null) {
        HandlerManager handlers = source.getHandlers();
        if (handlers != null) {
-        SelectionEvent<I> event = new SelectionEvent<I>();
-        event.setSelectedItem(selectedItem);
+        SelectionEvent<I> event = new SelectionEvent<I>(selectedItem);
          handlers.fireEvent(event);
        }
      }
@@ -63,12 +62,15 @@
      return TYPE;
    }

-  private I selectedItem;
+  private final I selectedItem;

    /**
     * Creates a new selection event.
+   *
+   * @param selectedItem selected item
     */
-  protected SelectionEvent() {
+  protected SelectionEvent(I selectedItem) {
+    this.selectedItem = selectedItem;
    }

    /**
@@ -91,14 +93,5 @@
    @Override
    protected Type<SelectionHandler<I>> getAssociatedType() {
      return (Type) TYPE;
-  }
-
-  /**
-   * Sets the selected item.
-   *
-   * @param selectedItem the selected item
-   */
-  protected final void setSelectedItem(I selectedItem) {
-    this.selectedItem = selectedItem;
    }
  }

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java
     
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java
     
Thu Nov 13 08:31:02 2008
@@ -44,8 +44,7 @@
      if (TYPE != null) {
        HandlerManager handlers = source.getHandlers();
        if (handlers != null && handlers.isEventHandled(TYPE)) {
-        ValueChangeEvent<I> event = new ValueChangeEvent<I>();
-        event.setValue(value);
+        ValueChangeEvent<I> event = new ValueChangeEvent<I>(value);
          handlers.fireEvent(event);
        }
      }
@@ -88,8 +87,10 @@

    /**
     * Creates a value change event.
+   * @param value the value
     */
-  protected ValueChangeEvent() {
+  protected ValueChangeEvent(I value) {
+    this.value = value;
    }

    /**
@@ -112,14 +113,5 @@
    @Override
    protected Type<ValueChangeHandler<I>> getAssociatedType() {
      return (Type) TYPE;
-  }
-
-  /**
-   * Sets the value.
-   *
-   * @param value the value
-   */
-  protected final void setValue(I value) {
-    this.value = value;
    }
  }

Modified:  
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java
==============================================================================
---  
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java    
 
(original)
+++  
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java    
 
Thu Nov 13 08:31:02 2008
@@ -93,7 +93,7 @@
    /**
     * The toString() for abstract event is overridden to avoid accidently
     * including class literals in the the compiled output. Use
-   * [EMAIL PROTECTED] AbstractEvent} #toDebugString to get more information 
about the
+   * [EMAIL PROTECTED] GwtEvent} #toDebugString to get more information about 
the
     * event.
     */
    @Override
@@ -104,7 +104,7 @@
    /**
     * Asserts that the event still should be accessed. All events are  
considered
     * to be "dead" after their original handler manager finishes firing  
them. An
-   * event can be revived by calling [EMAIL PROTECTED] AbstractEvent#revive()}.
+   * event can be revived by calling [EMAIL PROTECTED] GwtEvent#revive()}.
     */
    protected void assertLive() {
      assert (!dead) : "This event has already finished being processed by  
its original handler manager, so you can no longer access it";

Modified:  
branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java
==============================================================================
---  
branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java
   
(original)
+++  
branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java
   
Thu Nov 13 08:31:02 2008
@@ -66,11 +66,11 @@
    public void testSimpleFire() {
      simpleFire(BeforeSelectionEvent.getType(),
          new BeforeSelectionEvent<String>());
-    simpleFire(SelectionEvent.getType(), new SelectionEvent<String>());
-    simpleFire(CloseEvent.getType(), new CloseEvent<String>());
-    simpleFire(OpenEvent.getType(), new OpenEvent<String>());
+    simpleFire(SelectionEvent.getType(), new SelectionEvent<String>(null));
+    simpleFire(CloseEvent.getType(), new CloseEvent<String>(null,false));
+    simpleFire(OpenEvent.getType(), new OpenEvent<String>(null));
      simpleFire(ResizeEvent.getType(), new ResizeEvent(0, 0));
-    simpleFire(ValueChangeEvent.getType(), new ValueChangeEvent<String>());
+    simpleFire(ValueChangeEvent.getType(), new  
ValueChangeEvent<String>(null));
    }

    @SuppressWarnings("unchecked")

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to