[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4024.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4024
Score: Negative
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java
(r4024)
===============================================================================
Line 102: public final boolean isCanceled() {
-------------------------------------------------------------------------------
Please, no final methods without documentation. I really can't see the
point of this one, esp. if we're only expecting subclassing for testing
purposes.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4024
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
