[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4034.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4034
General Comment:
Fixed and committed, 4067
Line-by-line comments:
File:
/branches/1_6_clean_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
(r4034)
===============================================================================
Line 80: }
-------------------------------------------------------------------------------
because we kept changing our minds if this was public or protected!
File:
/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ui/TabBar.java
(r4034)
===============================================================================
Line 257: if (index >= getTabCount()) {
-------------------------------------------------------------------------------
RESPONSE
Yep, now committed with reasoning.
Line 356: }
-------------------------------------------------------------------------------
The deprecated is carried my the fact that in implements ClickListener.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4034
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
