[google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events. Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events
Line-by-line comments: File: /branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java (r3961) =============================================================================== Line 83: this(nativeEventTypeInt, eventNames[0], cached); ------------------------------------------------------------------------------- RESPONSE This is a proposed post 2.0 change, so it would be a while! File: /branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/CloseEvent.java (r3969) =============================================================================== Line 60: * @param <S> The event source. ------------------------------------------------------------------------------- RESPONSE For example, A tree can close a tree item. The tree is the event source, the tree item is the target. File: /branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java (r3969) =============================================================================== Line 60: ------------------------------------------------------------------------------- RESPONSE In certain rare cases, source can be null, for instance for window events we have no source object. Therefore, cannot use source here. File: /branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java (r4006) =============================================================================== Line 105: ------------------------------------------------------------------------------- RESPONSE it seemed like the type != null was not needed any more. So we now just assume type. Respond to these comments at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
