[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4137. Details are at http://code.google.com/p/google-web-toolkit/source/detail?r=4137
Score: Negative General Comment: Looks like a late night goofey example. Goofey comments are fine when they're buried in obscure code, but we don't want to confuse people in the examples. Line-by-line comments: File: /releases/1.6/user/javadoc/com/google/gwt/examples/LazyPanelExample.java (r4137) =============================================================================== Line 30: * A friendly little LazyPanel. ------------------------------------------------------------------------------- This might be a little cute. We usually don't include comments like these. Line 41: lazy.setVisible(false); ------------------------------------------------------------------------------- setVisible(false) isn't needed and might confuse people Respond to these comments at http://code.google.com/p/google-web-toolkit/source/detail?r=4137 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
