Fantastic, thanks! :) Tweaked to do initialization on the declaration lines for those static variables.
Committed r4225. On Tue, Dec 2, 2008 at 12:50 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: rjrjr, > > Message: > This looks great to me, Alex. And I think you're doing as right a thing > as you can WRT Chrome. Just a couple of nits noted below. > > > http://codereview.appspot.com/8696/diff/1/4 > File user/src/com/google/gwt/user/client/ui/impl/HyperlinkImplIE.java > (right): > > http://codereview.appspot.com/8696/diff/1/4#newcode31 > Line 31: ctrlisModifier = (getInternetExplorerVersion() >= 7); > Why the static block? Seems like you can just do this inline. > > http://codereview.appspot.com/8696/diff/1/5 > File > user/src/com/google/gwt/user/client/ui/impl/HyperlinkImplSafari.java > (right): > > http://codereview.appspot.com/8696/diff/1/5#newcode31 > Line 31: shiftIsModifier = onChrome(); > again, don't see the need for the block. > > Description: > Hello Ray :) > > Would you take a look at this patch for the Hyperlink widget? It takes > the behavior from incubator's HyperlinkOverride widget and moves it > into the core Hyperlink. > > This means that on a click event with a modifier key (with specific > keys counting, per-browser), we let the default browser action happen, > usually something like opening that link in a new tab. > > I have a small doubt about this patch with regard to Chrome, but > please let me know what you think -- as far as I can tell, Chrome > doesn't do an "open in new tab" when you ctrl-click on a link to a URL > fragment (for example, our history tokens) -- but on the assumption > that this may change soon, this patch tries to do the behavior that > Chrome does for regular links, which is just like Firefox. > > Patch is intended for the 1.6 release branch, r4214. > > Thanks! > > -- > Alex Rudnick > swe, gwt, atl > > > Please review this at http://codereview.appspot.com/8696 > > Affected files: > user/src/com/google/gwt/user/Hyperlink.gwt.xml > user/src/com/google/gwt/user/User.gwt.xml > user/src/com/google/gwt/user/client/ui/Hyperlink.java > user/src/com/google/gwt/user/client/ui/impl/HyperlinkImpl.java > user/src/com/google/gwt/user/client/ui/impl/HyperlinkImplIE.java > user/src/com/google/gwt/user/client/ui/impl/HyperlinkImplOpera.java > user/src/com/google/gwt/user/client/ui/impl/HyperlinkImplSafari.java > > > -- Alex Rudnick swe, gwt, atl --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
