[gwt-contrib] [google-web-toolkit commit] r4232 - branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui

[codesite-noreply]

Author: [EMAIL PROTECTED]
Date: Tue Dec  2 14:14:39 2008
New Revision: 4232

Modified:
     
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/DateValueChangeTester.java
     
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java

Log:
Punches up testing to ensure that setValue(null) works, and that the
default value of HasValue<Date> objects is null.

TBR ecc
submitted by rjrjr


Modified:  
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/DateValueChangeTester.java
==============================================================================
---  
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/DateValueChangeTester.java
       
(original)
+++  
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/DateValueChangeTester.java
       
Tue Dec  2 14:14:39 2008
@@ -35,22 +35,36 @@
    }

    private final HasValue<Date> subject;
+
+  /**
+   * The HasValue<Date> to be tested. It should have been freshly created
+   * before handing it to this tester.
+   */
    public DateValueChangeTester(HasValue<Date> subject) {
      this.subject = subject;
    }

+  /**
+   * Asserts that the default value is null, checks that value change
+   * events do and don't fire when appropriate, and that getValue() always
+   * returns what was handed to getValue().
+   */
    @SuppressWarnings("deprecation")
    public void run() {
+    TestCase.assertNull(subject.getValue());
+
+    DateValueChangeTester.Handler h = new Handler();
+    subject.addValueChangeHandler(h);
+
      subject.setValue(null);
      TestCase.assertNull(subject.getValue());
+    TestCase.assertNull(h.received);

      Date able = new Date(1999, 5, 15);
      subject.setValue(able);
      TestCase.assertEquals(able, subject.getValue());
-
-    DateValueChangeTester.Handler h = new Handler();
-    subject.addValueChangeHandler(h);
-
+    TestCase.assertNull(h.received);
+
      subject.setValue(able);
      TestCase.assertNull(h.received);


Modified:  
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
==============================================================================
---  
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
         
(original)
+++  
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
         
Tue Dec  2 14:14:39 2008
@@ -98,11 +98,16 @@

    public void testValueChangeEvent() {
      TextBoxBase tb = createTextBoxBase();
-
      // To work cross-platform, the tb must be added to the root panel.
      RootPanel.get().add(tb);
+
      Handler h = new Handler();
      tb.addValueChangeHandler(h);
+
+    tb.setValue(null);
+    assertEquals("", tb.getValue());
+    assertNull(h.received);
+
      tb.setText("able");
      assertEquals("able", tb.getValue());
      assertNull(h.received);
@@ -110,6 +115,7 @@
      tb.setValue("able");
      assertEquals("able", tb.getValue());
      assertNull(h.received);
+
      tb.setValue("baker");
      assertNull(h.received);


--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---