[gwt-contrib] [google-web-toolkit commit] r4235 - in branches/1_6_datepicker: samples/showcase/src/com/google/gwt/sample/showcase/client/co...

[codesite-noreply]

Author: [EMAIL PROTECTED]
Date: Tue Dec  2 16:08:25 2008
New Revision: 4235

Modified:
     
branches/1_6_datepicker/samples/showcase/src/com/google/gwt/sample/showcase/client/content/widgets/CwDatePicker.java
     
branches/1_6_datepicker/user/javadoc/com/google/gwt/examples/DatePickerExample.java
     
branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/DatePicker.java

Log:
Tweaks in response to review of r4188. Use Labels instead of TextBoxes in  
examples,
and explain use of VerticalPanel in DatePicker.

TBR: jlabanca
submitter: rjrjr



Modified:  
branches/1_6_datepicker/samples/showcase/src/com/google/gwt/sample/showcase/client/content/widgets/CwDatePicker.java
==============================================================================
---  
branches/1_6_datepicker/samples/showcase/src/com/google/gwt/sample/showcase/client/content/widgets/CwDatePicker.java
     
(original)
+++  
branches/1_6_datepicker/samples/showcase/src/com/google/gwt/sample/showcase/client/content/widgets/CwDatePicker.java
     
Tue Dec  2 16:08:25 2008
@@ -24,7 +24,7 @@
  import  
com.google.gwt.sample.showcase.client.ShowcaseAnnotations.ShowcaseSource;
  import  
com.google.gwt.sample.showcase.client.ShowcaseAnnotations.ShowcaseStyle;
  import com.google.gwt.user.client.ui.HTML;
-import com.google.gwt.user.client.ui.TextBox;
+import com.google.gwt.user.client.ui.Label;
  import com.google.gwt.user.client.ui.VerticalPanel;
  import com.google.gwt.user.client.ui.Widget;
  import com.google.gwt.user.datepicker.client.DateBox;
@@ -88,15 +88,14 @@
    public Widget onInitialize() {
      // Create a basic date picker
      DatePicker datePicker = new DatePicker();
-    final TextBox textBox = new TextBox();
-    textBox.setEnabled(false);
+    final Label text = new Label();

      // Set the value in the text box when the user selects a date
      datePicker.addValueChangeHandler(new ValueChangeHandler<Date>() {
        public void onValueChange(ValueChangeEvent<Date> event) {
          Date date = event.getValue();
          String dateString =  
DateTimeFormat.getMediumDateFormat().format(date);
-        textBox.setValue(dateString);
+        text.setText(dateString);
        }
      });

@@ -109,7 +108,7 @@
      // Combine the widgets into a panel and return them
      VerticalPanel vPanel = new VerticalPanel();
      vPanel.add(new HTML(constants.cwDatePickerLabel()));
-    vPanel.add(textBox);
+    vPanel.add(text);
      vPanel.add(datePicker);
      vPanel.add(new HTML(constants.cwDatePickerBoxLabel()));
      vPanel.add(dateBox);

Modified:  
branches/1_6_datepicker/user/javadoc/com/google/gwt/examples/DatePickerExample.java
==============================================================================
---  
branches/1_6_datepicker/user/javadoc/com/google/gwt/examples/DatePickerExample.java
      
(original)
+++  
branches/1_6_datepicker/user/javadoc/com/google/gwt/examples/DatePickerExample.java
      
Tue Dec  2 16:08:25 2008
@@ -19,8 +19,8 @@
  import com.google.gwt.event.logical.shared.ValueChangeEvent;
  import com.google.gwt.event.logical.shared.ValueChangeHandler;
  import com.google.gwt.i18n.client.DateTimeFormat;
+import com.google.gwt.user.client.ui.Label;
  import com.google.gwt.user.client.ui.RootPanel;
-import com.google.gwt.user.client.ui.TextBox;
  import com.google.gwt.user.datepicker.client.DatePicker;

  import java.util.Date;
@@ -30,14 +30,14 @@
    public void onModuleLoad() {
      // Create a date picker
      DatePicker datePicker = new DatePicker();
-    final TextBox textBox = new TextBox();
+    final Label text = new Label();

      // Set the value in the text box when the user selects a date
      datePicker.addValueChangeHandler(new ValueChangeHandler<Date>() {
        public void onValueChange(ValueChangeEvent<Date> event) {
          Date date = event.getValue();
          String dateString =  
DateTimeFormat.getMediumDateFormat().format(date);
-        textBox.setValue(dateString);
+        text.setText(dateString);
        }
      });

@@ -45,7 +45,7 @@
      datePicker.setValue(new Date(), true);

      // Add the widgets to the page
-    RootPanel.get().add(textBox);
+    RootPanel.get().add(text);
      RootPanel.get().add(datePicker);
    }
  }

Modified:  
branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/DatePicker.java
==============================================================================
---  
branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/DatePicker.java
   
(original)
+++  
branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/DatePicker.java
   
Tue Dec  2 16:08:25 2008
@@ -609,6 +609,10 @@
     * Sets up the date picker.
     */
    protected void setup() {
+    /*
+     * Use a table (VerticalPanel) to get shrink-to-fit behavior. Divs  
expand to
+     * fill the available width, so we'd need to give it a size.
+     */
      VerticalPanel panel = new VerticalPanel();
      initWidget(panel);
      setStyleName(panel.getElement(), css.datePicker());

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---