Author: [EMAIL PROTECTED]
Date: Wed Dec 3 15:31:00 2008
New Revision: 4242
Modified:
trunk/dev/oophm/overlay/com/google/gwt/dev/GWTShell.java
trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValue.java
trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValueGlue.java
trunk/dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java
trunk/dev/oophm/src/com/google/gwt/dev/shell/MethodDispatch.java
trunk/dev/oophm/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
Log:
OOPHM Checkstyle warning removal.
Patch by: jat
Review by: scottb (TBR)
Modified: trunk/dev/oophm/overlay/com/google/gwt/dev/GWTShell.java
==============================================================================
--- trunk/dev/oophm/overlay/com/google/gwt/dev/GWTShell.java (original)
+++ trunk/dev/oophm/overlay/com/google/gwt/dev/GWTShell.java Wed Dec 3
15:31:00 2008
@@ -308,6 +308,12 @@
}
}
+ public ModuleSpaceHost createModuleSpaceHost(BrowserWidget widget,
+ String moduleName) throws UnableToCompleteException {
+ // TODO(jat): implement method createModuleSpaceHost
+ return null;
+ }
+
public ModuleSpaceHost createModuleSpaceHost(TreeLogger mainLogger,
String moduleName, String userAgent, String remoteSocket)
throws UnableToCompleteException {
@@ -365,6 +371,12 @@
return GWTShell.this.normalizeURL(whatTheUserTyped);
}
+ public BrowserWidget openNewBrowserWindow()
+ throws UnableToCompleteException {
+ // TODO(jat): is this ok?
+ throw new UnableToCompleteException();
+ }
+
public void unloadModule(ModuleSpaceHost moduleSpaceHost) {
ModulePanel tab = moduleTabs.remove(moduleSpaceHost);
if (tab != null) {
@@ -389,18 +401,6 @@
alreadySeenModules.add(moduleName);
assert (moduleDef != null) : "Required module state is absent";
return moduleDef;
- }
-
- public ModuleSpaceHost createModuleSpaceHost(BrowserWidget widget,
- String moduleName) throws UnableToCompleteException {
- // TODO(jat): implement method createModuleSpaceHost
- return null;
- }
-
- public BrowserWidget openNewBrowserWindow()
- throws UnableToCompleteException {
- // TODO(jat): is this ok?
- throw new UnableToCompleteException();
}
}
Modified: trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValue.java
==============================================================================
--- trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValue.java
(original)
+++ trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValue.java Wed Dec
3 15:31:00 2008
@@ -213,7 +213,7 @@
/**
* Set the JS object to be null.
*
- * @throws HostedModeException
+ * @throws com.google.gwt.dev.shell.HostedModeException
*/
public abstract void setNull();
Modified: trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValueGlue.java
==============================================================================
--- trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValueGlue.java
(original)
+++ trunk/dev/oophm/overlay/com/google/gwt/dev/shell/JsValueGlue.java Wed
Dec 3 15:31:00 2008
@@ -87,8 +87,8 @@
* @param type expected type of the returned object
* @param msgPrefix a prefix for error/warning messages
* @return the object reference
- * @throws HostedModeException if the JavaScript object is not
assignable to
- * the supplied type.
+ * @throws com.google.gwt.dev.shell.HostedModeException if the JavaScript
+ * object is not assignable to the supplied type.
*/
@SuppressWarnings("unchecked")
public static <T> T get(JsValue value, CompilingClassLoader cl,
Modified:
trunk/dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java
==============================================================================
--- trunk/dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java
(original)
+++ trunk/dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java
Wed Dec 3 15:31:00 2008
@@ -89,15 +89,15 @@
convertToJsValue(ccl, remoteObjects, returnValue, returnJsValue);
if (msg.isException()) {
if (returnValue.isNull() || returnValue.isUndefined()) {
- throw ModuleSpaceOOPHM.createJavaScriptException(ccl, null);
+ throw ModuleSpace.createJavaScriptException(ccl, null);
} else if (returnValue.isString()) {
- throw ModuleSpaceOOPHM.createJavaScriptException(ccl,
+ throw ModuleSpace.createJavaScriptException(ccl,
returnValue.getString());
} else if (returnValue.isJsObject()) {
Object jso = JsValueGlue.createJavaScriptObject(returnJsValue,
ccl);
- throw ModuleSpaceOOPHM.createJavaScriptException(ccl, jso);
+ throw ModuleSpace.createJavaScriptException(ccl, jso);
} else if (returnValue.isJavaObject()) {
Object object =
remoteObjects.get(returnValue.getJavaObject().getRefid());
@@ -106,11 +106,11 @@
throw (Throwable) (target);
} else {
// JS throwing random Java Objects, which we'll wrap is
JSException
- throw ModuleSpaceOOPHM.createJavaScriptException(ccl, target);
+ throw ModuleSpace.createJavaScriptException(ccl, target);
}
}
// JS throwing random primitives, which we'll wrap is JSException
- throw ModuleSpaceOOPHM.createJavaScriptException(ccl,
+ throw ModuleSpace.createJavaScriptException(ccl,
returnValue.getValue().toString());
}
} catch (IOException e) {
Modified: trunk/dev/oophm/src/com/google/gwt/dev/shell/MethodDispatch.java
==============================================================================
--- trunk/dev/oophm/src/com/google/gwt/dev/shell/MethodDispatch.java
(original)
+++ trunk/dev/oophm/src/com/google/gwt/dev/shell/MethodDispatch.java Wed
Dec 3 15:31:00 2008
@@ -112,7 +112,7 @@
// See if we're in the process of throwing a JavaScriptObject; remove
// it from the JavaScriptException object and throw the JS object
instead
- Object jsoException = ModuleSpaceOOPHM.getJavaScriptExceptionException(
+ Object jsoException = ModuleSpace.getJavaScriptExceptionException(
classLoader, t);
if (jsoException != null) {
Modified: trunk/dev/oophm/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
==============================================================================
--- trunk/dev/oophm/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
(original)
+++ trunk/dev/oophm/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java Wed
Dec 3 15:31:00 2008
@@ -87,6 +87,15 @@
}
/**
+ *
+ */
+ @Override
+ protected void createStaticDispatcher(TreeLogger logger) {
+ channel.loadJsni(
+ "function __defineStatic(__arg0) { window.__static = __arg0; }");
+ }
+
+ /**
* Invoke a JS method and return its value.
*
* @param name method name to invoke
@@ -127,14 +136,5 @@
@Override
protected DispatchObject getStaticDispatcher() {
return new JsValueOOPHM.DispatchObjectOOPHM(getIsolatedClassLoader());
- }
-
- /**
- *
- */
- @Override
- protected void createStaticDispatcher(TreeLogger logger) {
- channel.loadJsni(
- "function __defineStatic(__arg0) { window.__static = __arg0; }");
}
}
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
